enable channel tests in netcore20 (#1154)

* enable channel tests in netcore20

Author: cijothomas

Test/ServerTelemetryChannel.Test/Shared.Tests/Implementation/FileSystemTest.cs

@@ -1,6 +1,6 @@
 namespace Microsoft.ApplicationInsights.WindowsServer.TelemetryChannel.Implementation
 {
-#if !NETCOREAPP
+#if !NETCOREAPP1_1
     using System;
     using System.IO;
     using System.Linq;
@@ -25,7 +25,7 @@ protected static FileInfo CreatePlatformFile(string fileName, DirectoryInfo fold
 
         protected static DirectoryInfo GetLocalFolder()
         {
-            return new DirectoryInfo(Environment.GetFolderPath(Environment.SpecialFolder.ApplicationData));
+            return new DirectoryInfo(Environment.GetFolderPath(Environment.SpecialFolder.ApplicationData, Environment.SpecialFolderOption.Create));
         }
 
         protected static DirectoryInfo CreatePlatformFolder(string uniqueName)

Test/ServerTelemetryChannel.Test/Shared.Tests/Implementation/PlatformFileTest.cs

@@ -1,6 +1,6 @@
 namespace Microsoft.ApplicationInsights.WindowsServer.TelemetryChannel.Implementation
 {
-#if !NETCOREAPP
+#if !NETCOREAPP1_1
     using System;
     using System.IO;
     using System.Security.AccessControl;
@@ -179,8 +179,10 @@ public void ThrowsIOExceptionWhenFileIsAlreadyOpen()
             }
 
             [TestMethod]
+            [TestCategory("WindowsOnly")]
             public void ThrowsUnauthorizedAccessExceptionWhenProcessHasNoRightToWriteToFile()
             {
+                // Only on Windows as the APIs are not available in Linux.                
                 using (new FileAccessDenier(this.platformFile, FileSystemRights.Write))
                 { 
                     var file = new PlatformFile(this.platformFile);

Test/ServerTelemetryChannel.Test/Shared.Tests/Implementation/PlatformFolderTest.cs

@@ -1,6 +1,6 @@
 namespace Microsoft.ApplicationInsights.WindowsServer.TelemetryChannel.Implementation
 {
-#if !NETCOREAPP
+#if !NETCOREAPP1_1
     using System;
     using System.Collections.Generic;
     using System.IO;
@@ -108,9 +108,12 @@ public void ReturnsEnumerableOfObjectsRepresentingExistingFiles()
             }
 
             [TestMethod]
+            [TestCategory("WindowsOnly")]
             public void ThrowsUnauthorizedAccessExceptionWhenProcessDoesNotHaveRightToListDirectory()
             {
                 Trace.WriteLine(string.Format("{0} Blocking Listing Permission on: {1} ",DateTime.Now.ToLongTimeString(), this.storageFolder.FullName));
+                // Only on Windows as the APIs are not available in Linux.
+                // The product also does not this this.
                 using (new DirectoryAccessDenier(this.storageFolder, FileSystemRights.ListDirectory))
                 {
                     var folder = new PlatformFolder(this.storageFolder);
@@ -176,10 +179,13 @@ public void ThrowsIOExceptionWhenDesiredFileNameIsTooLong()
                 AssertEx.Throws<PathTooLongException>(() => folder.CreateFile(new string('F', 1024)));
             }
 
-            [TestMethod]            
+            [TestMethod]
+            [TestCategory("WindowsOnly")]
             public void ThrowsUnauthorizedAccessExceptionWhenProcessDoesNotHaveRightToCreateFile()
             {
                 Trace.WriteLine(string.Format("{0} Blocking Listing Permission on: {1} ", DateTime.Now.ToLongTimeString(), this.storageFolder.FullName));
+                // Only on Windows as the APIs are not available in Linux.
+                // The product also does not this this.
                 using (new DirectoryAccessDenier(this.storageFolder, FileSystemRights.CreateFiles))
                 { 
                     var folder = new PlatformFolder(this.storageFolder);