Skip to content

Commit 8426b18

Browse files
committed
drivers: tty: serial: timbuart: fix formatting issues
Fix checkpatch warnings: WARNING: Missing a blank line after declarations torvalds#43: FILE: drivers/tty/serial/timbuart.c:43: + u32 ier = ioread32(port->membase + TIMBUART_IER) & ~RXFLAGS; + iowrite32(ier, port->membase + TIMBUART_IER); WARNING: Missing a blank line after declarations torvalds#50: FILE: drivers/tty/serial/timbuart.c:50: + u32 ier = ioread32(port->membase + TIMBUART_IER) & ~TXBAE; + iowrite32(ier, port->membase + TIMBUART_IER); WARNING: Missing a blank line after declarations torvalds#86: FILE: drivers/tty/serial/timbuart.c:86: + u8 ch = ioread8(port->membase + TIMBUART_RXFIFO); + port->icount.rx++; WARNING: Missing a blank line after declarations torvalds#202: FILE: drivers/tty/serial/timbuart.c:202: + u8 cts = ioread8(port->membase + TIMBUART_CTRL); + dev_dbg(port->dev, "%s - cts %x\n", __func__, cts); WARNING: Block comments use * on subsequent lines torvalds#296: FILE: drivers/tty/serial/timbuart.c:296: + /* The serial layer calls into this once with old = NULL when setting + up initially */ WARNING: Block comments use a trailing */ on a separate line torvalds#296: FILE: drivers/tty/serial/timbuart.c:296: Signed-off-by: Enrico Weigelt <[email protected]>
1 parent c7b0ade commit 8426b18

File tree

1 file changed

+6
-2
lines changed

1 file changed

+6
-2
lines changed

drivers/tty/serial/timbuart.c

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -40,13 +40,15 @@ static void timbuart_stop_rx(struct uart_port *port)
4040
{
4141
/* spin lock held by upper layer, disable all RX interrupts */
4242
u32 ier = ioread32(port->membase + TIMBUART_IER) & ~RXFLAGS;
43+
4344
iowrite32(ier, port->membase + TIMBUART_IER);
4445
}
4546

4647
static void timbuart_stop_tx(struct uart_port *port)
4748
{
4849
/* spinlock held by upper layer, disable TX interrupt */
4950
u32 ier = ioread32(port->membase + TIMBUART_IER) & ~TXBAE;
51+
5052
iowrite32(ier, port->membase + TIMBUART_IER);
5153
}
5254

@@ -83,6 +85,7 @@ static void timbuart_rx_chars(struct uart_port *port)
8385

8486
while (ioread32(port->membase + TIMBUART_ISR) & RXDP) {
8587
u8 ch = ioread8(port->membase + TIMBUART_RXFIFO);
88+
8689
port->icount.rx++;
8790
tty_insert_flip_char(tport, ch, TTY_NORMAL);
8891
}
@@ -199,6 +202,7 @@ static void timbuart_tasklet(unsigned long arg)
199202
static unsigned int timbuart_get_mctrl(struct uart_port *port)
200203
{
201204
u8 cts = ioread8(port->membase + TIMBUART_CTRL);
205+
202206
dev_dbg(port->dev, "%s - cts %x\n", __func__, cts);
203207

204208
if (cts & TIMBUART_CTRL_CTS)
@@ -293,7 +297,8 @@ static void timbuart_set_termios(struct uart_port *port,
293297
baud = baudrates[bindex];
294298

295299
/* The serial layer calls into this once with old = NULL when setting
296-
up initially */
300+
* up initially
301+
*/
297302
if (old)
298303
tty_termios_copy_hw(termios, old);
299304
tty_termios_encode_baud_rate(termios, baud, baud);
@@ -500,4 +505,3 @@ module_platform_driver(timbuart_platform_driver);
500505
MODULE_DESCRIPTION("Timberdale UART driver");
501506
MODULE_LICENSE("GPL v2");
502507
MODULE_ALIAS("platform:timb-uart");
503-

0 commit comments

Comments
 (0)