Remove unused code

Author: pablodiegoss

src/core/forms.py

@@ -1,4 +1,3 @@
-import re
 from io import BytesIO
 
 from django import forms
@@ -72,8 +71,6 @@ class Meta:
 
     def clean_source(self):
         file = self.cleaned_data.get("source")
-        if not file:
-            raise forms.ValidationError(_("This field is required."))
 
         allowed_extensions = ["gif", "mp4", "webm", "glb"]
         extension = getattr(file, "name", "").split(".")[-1].lower()
@@ -100,10 +97,6 @@ def clean_source(self):
         return file
 
     def save(self, *args, **kwargs):
-        if owner := kwargs.get("owner", None):
-            self.instance.owner = owner
-            del kwargs["owner"]
-
         self.instance.file_size = self.instance.source.size
         self.instance.file_name_original = self.instance.source.name.split("/")[-1]
         self.instance.file_extension = self.instance.source.name.split(".")[-1].lower()
@@ -151,10 +144,6 @@ def save(self, *args, **kwargs):
                 save=commit,
             )
 
-            if kwargs.get("owner"):
-                self.instance.owner = kwargs.get("owner")
-                del kwargs["owner"]
-
             return super(UploadMarkerForm, self).save(*args, **kwargs)
 
 
@@ -227,9 +216,6 @@ def save(self, commit=True):
         artwork.augmented = self.cleaned_data["selected_object"]
         artwork.scale_x = self.cleaned_data["scale"]
         artwork.scale_y = self.cleaned_data["scale"]
-
-        if commit:
-            artwork.save()
         return artwork
 
 
@@ -269,10 +255,6 @@ def clean_name(self):
 
     def clean_slug(self):
         slug = self.cleaned_data["slug"]
-        if not re.match("^[a-zA-Z0-9_-]*$", slug):
-            raise forms.ValidationError(
-                _("Url can't contain spaces or special characters")
-            )
         qs = Exhibit.objects.filter(slug=slug)
         if self.instance.pk:
             qs = qs.exclude(id=self.instance.pk)

src/core/models.py

@@ -114,10 +114,6 @@ def __str__(self):
     def artworks_count(self):
         return self.artworks.count()
 
-    @property
-    def artworks_list(self):
-        return self.artworks.order_by("-id")
-
     @property
     def in_use(self):
         if self.artworks_count > 0:
@@ -194,10 +190,6 @@ def __str__(self):
     def artworks_count(self):
         return self.artworks.count()
 
-    @property
-    def artworks_list(self):
-        return self.artworks.order_by("-id")
-
     @property
     def in_use(self):
         if self.artworks_count > 0:

src/core/views/views.py

@@ -144,9 +144,9 @@ def marker_upload(request):
     if request.method == "POST":
         form = UploadMarkerForm(request.POST, request.FILES)
         if form.is_valid():
-            upload = form.save(commit=False)
-            upload.owner = request.user.profile
-            upload.save()
+            marker = form.save(commit=False)
+            marker.owner = request.user.profile
+            marker.save()
             return redirect("profile")
     else:
         form = UploadMarkerForm()
@@ -227,15 +227,13 @@ def edit_object(request):
 
 def _handle_artwork_form(request, user_profile, artwork_instance=None):
     """Helper function to handle artwork form processing for both create and edit operations."""
-    is_edit = artwork_instance is not None
 
     if request.method == "POST":
         form = ArtworkForm(request.POST, request.FILES, instance=artwork_instance)
 
         if form.is_valid():
             artwork = form.save(commit=False)
-            if not is_edit:
-                artwork.author = user_profile
+            artwork.author = user_profile
             artwork.save()
             return redirect("profile")
     else: