Skip to content

Commit 5ffd807

Browse files
authored
Add missing strategy to CI (#667)
1 parent 8da7c14 commit 5ffd807

File tree

3 files changed

+18
-10
lines changed

3 files changed

+18
-10
lines changed

.github/workflows/meilisearch-beta-tests.yml

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -27,14 +27,15 @@ jobs:
2727
tests:
2828
runs-on: ubuntu-latest
2929
needs: ['meilisearch-version']
30+
name: integration-tests-against-rc (PHP ${{ matrix.php-version }}) (${{ matrix.http-client }})
3031
services:
3132
meilisearch:
3233
image: getmeili/meilisearch:${{ needs.meilisearch-version.outputs.version }}
33-
env:
34-
MEILI_MASTER_KEY: 'masterKey'
35-
MEILI_NO_ANALYTICS: 'true'
3634
ports:
3735
- '7700:7700'
36+
env:
37+
MEILI_MASTER_KEY: masterKey
38+
MEILI_NO_ANALYTICS: true
3839
strategy:
3940
matrix:
4041
php-version: ['7.4', '8.0', '8.1', '8.2', '8.3']
@@ -47,7 +48,6 @@ jobs:
4748
- php-version: '8.1'
4849
http-client: 'Symfony-HttpClient'
4950

50-
name: integration-tests-against-rc (PHP ${{ matrix.php-version }}) (${{ matrix.http-client }})
5151
steps:
5252
- name: Checkout code
5353
uses: actions/checkout@v4

.github/workflows/pre-release-tests.yml

Lines changed: 12 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -31,14 +31,22 @@ jobs:
3131
services:
3232
meilisearch:
3333
image: getmeili/meilisearch:${{ needs.meilisearch-version.outputs.version }}
34-
env:
35-
MEILI_MASTER_KEY: 'masterKey'
36-
MEILI_NO_ANALYTICS: 'true'
3734
ports:
3835
- '7700:7700'
36+
env:
37+
MEILI_MASTER_KEY: masterKey
38+
MEILI_NO_ANALYTICS: true
3939
strategy:
4040
matrix:
41-
php-versions: ['7.4', '8.0', '8.1', '8.2', '8.3']
41+
php-version: ['7.4', '8.0', '8.1', '8.2', '8.3']
42+
http-client: ['Guzzle-7', 'Guzzle-7-Adapter', 'Symfony-HttpClient', 'PHP-HTTP-CurlClient', 'Kriswallsmith-Buzz']
43+
exclude:
44+
- php-version: '7.4'
45+
http-client: 'Symfony-HttpClient'
46+
- php-version: '8.0'
47+
http-client: 'Symfony-HttpClient'
48+
- php-version: '8.1'
49+
http-client: 'Symfony-HttpClient'
4250
steps:
4351
- name: Checkout code
4452
uses: actions/checkout@v4

.github/workflows/tests.yml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -66,11 +66,12 @@ jobs:
6666
# Will still run for each push to bump-meilisearch-v*
6767
if: github.event_name != 'pull_request' || !startsWith(github.base_ref, 'bump-meilisearch-v')
6868
runs-on: ubuntu-latest
69+
name: integration-tests (PHP ${{ matrix.php-version }}) (${{ matrix.http-client }})
6970
services:
7071
meilisearch:
7172
image: getmeili/meilisearch:latest
7273
ports:
73-
- 7700:7700
74+
- '7700:7700'
7475
env:
7576
MEILI_MASTER_KEY: masterKey
7677
MEILI_NO_ANALYTICS: true
@@ -86,7 +87,6 @@ jobs:
8687
- php-version: '8.1'
8788
http-client: 'Symfony-HttpClient'
8889

89-
name: integration-tests (PHP ${{ matrix.php-version }}) (${{ matrix.http-client }})
9090
steps:
9191
- uses: actions/checkout@v4
9292

0 commit comments

Comments
 (0)