Skip to content

Commit 8bd506c

Browse files
authored
Merge pull request #1624 from maxmind/greg/eng-1733
Improve release script reliability (ENG-1733)
2 parents 7ef165b + 733f03a commit 8bd506c

File tree

1 file changed

+32
-1
lines changed

1 file changed

+32
-1
lines changed

dev-bin/release.sh

Lines changed: 32 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,37 @@
22

33
set -eu -o pipefail
44

5+
# Pre-flight checks - verify all required tools are available and configured
6+
# before making any changes to the repository
7+
8+
check_command() {
9+
if ! command -v "$1" &>/dev/null; then
10+
echo "Error: $1 is not installed or not in PATH"
11+
exit 1
12+
fi
13+
}
14+
15+
# Verify gh CLI is authenticated
16+
if ! gh auth status &>/dev/null; then
17+
echo "Error: gh CLI is not authenticated. Run 'gh auth login' first."
18+
exit 1
19+
fi
20+
21+
# Verify we can access this repository via gh
22+
if ! gh repo view --json name &>/dev/null; then
23+
echo "Error: Cannot access repository via gh. Check your authentication and repository access."
24+
exit 1
25+
fi
26+
27+
# Verify git can connect to the remote (catches SSH key issues, etc.)
28+
if ! git ls-remote origin &>/dev/null; then
29+
echo "Error: Cannot connect to git remote. Check your git credentials/SSH keys."
30+
exit 1
31+
fi
32+
33+
check_command node
34+
check_command npm
35+
536
# Check that we're not on the main branch
637
current_branch=$(git branch --show-current)
738
if [ "$current_branch" = "main" ]; then
@@ -73,7 +104,7 @@ git diff
73104
echo $'\nRelease notes:'
74105
echo "$notes"
75106

76-
read -e -p "Commit changes and create release? (y/n) " should_continue
107+
read -r -e -p "Commit changes and create release? (y/n) " should_continue
77108

78109
if [ "$should_continue" != "y" ]; then
79110
echo "Aborting"

0 commit comments

Comments
 (0)