MSC2918: temp: mark the access token as used only once

This is a temporary fix to work around the cache. It's only there to
confirm it broke tests, and check if CI passes with this fix.

Author: sandhose

synapse/api/auth.py

@@ -253,6 +253,12 @@ async def get_user_by_req(
             if not user_info.token_used and token_id is not None:
                 await self.store.mark_access_token_as_used(token_id)
 
+                # TODO: this is a temporary fix because if we don't do this, it
+                # will do the update every time because of the cache. This
+                # required unfreezing the TokenLookupResult class, which is not
+                # ideal.
+                user_info.token_used = True
+
             requester = create_requester(
                 user_info.user_id,
                 token_id,

synapse/storage/databases/main/registration.py

@@ -40,7 +40,7 @@
 logger = logging.getLogger(__name__)
 
 
-@attr.s(frozen=True, slots=True)
+@attr.s(slots=True)
 class TokenLookupResult:
     """Result of looking up an access token.