Do not instantiate recv, it is already an instance.

This just happens to work since the default implementation (via the
HostnameEndpoint) happens to create a class that only has static
methods, then passes the class (without instantiating it), presumedly
to save memory.

Author: clokep

synapse/http/client.py

@@ -151,12 +151,10 @@ def __init__(
     def resolveHostName(
         self, recv: IResolutionReceiver, hostname: str, portNumber: int = 0
     ) -> IResolutionReceiver:
-
-        r = recv()
         addresses = []  # type: List[IAddress]
 
         def _callback() -> None:
-            r.resolutionBegan(None)
+            recv.resolutionBegan(None)
 
             has_bad_ip = False
             for i in addresses:
@@ -176,8 +174,8 @@ def _callback() -> None:
             # valid results.
             if not has_bad_ip:
                 for i in addresses:
-                    r.addressResolved(i)
-            r.resolutionComplete()
+                    recv.addressResolved(address)
+            recv.resolutionComplete()
 
         @provider(IResolutionReceiver)
         class EndpointReceiver:
@@ -197,7 +195,7 @@ def resolutionComplete() -> None:
             EndpointReceiver, hostname, portNumber=portNumber
         )
 
-        return r
+        return recv
 
 
 @implementer(ISynapseReactor)