Merge pull request #12156 from matrix-org/dbkr/split_unread_counts

Make threads activity centre labs flag split out unread counts

Author: dbkr

src/RoomNotifs.ts

@@ -81,9 +81,12 @@ export function setRoomNotifsState(client: MatrixClient, roomId: string, newStat
 }
 
 export function getUnreadNotificationCount(room: Room, type: NotificationCountType, threadId?: string): number {
-    let notificationCount = !!threadId
-        ? room.getThreadUnreadNotificationCount(threadId, type)
-        : room.getUnreadNotificationCount(type);
+    const countShownForRoom = (): number =>
+        SettingsStore.getValue("threadsActivityCentre")
+            ? room.getRoomUnreadNotificationCount(type)
+            : room.getUnreadNotificationCount(type);
+
+    let notificationCount = !!threadId ? room.getThreadUnreadNotificationCount(threadId, type) : countShownForRoom();
 
     // Check notification counts in the old room just in case there's some lost
     // there. We only go one level down to avoid performance issues, and theory

src/Unread.ts

@@ -57,7 +57,12 @@ export function doesRoomHaveUnreadMessages(room: Room): boolean {
         return false;
     }
 
-    for (const withTimeline of [room, ...room.getThreads()]) {
+    const toCheck: Array<Room | Thread> = [room];
+    if (!SettingsStore.getValue("threadsActivityCentre")) {
+        toCheck.push(...room.getThreads());
+    }
+
+    for (const withTimeline of toCheck) {
         if (doesTimelineHaveUnreadMessages(room, withTimeline.timeline)) {
             // We found an unread, so the room is unread
             return true;

src/settings/Settings.tsx

@@ -1109,6 +1109,7 @@ export const SETTINGS: { [setting: string]: ISetting } = {
     "threadsActivityCentre": {
         supportedLevels: LEVELS_ACCOUNT_SETTINGS,
         labsGroup: LabGroup.Threads,
+        controller: new ReloadOnChangeController(),
         displayName: _td("labs|threads_activity_centre"),
         default: false,
         isFeature: true,

test/components/views/rooms/LegacyRoomHeader-test.tsx

@@ -792,8 +792,11 @@ function createRoom(info: IRoomCreationInfo) {
     const userId = client.getUserId()!;
     if (info.isDm) {
         client.getAccountData = (eventType) => {
-            expect(eventType).toEqual("m.direct");
-            return mkDirectEvent(roomId, userId, info.userIds);
+            if (eventType === "m.direct") {
+                return mkDirectEvent(roomId, userId, info.userIds);
+            } else {
+                return undefined;
+            }
         };
     }
 

test/stores/RoomNotificationStateStore-test.ts

@@ -125,6 +125,7 @@ describe("RoomNotificationStateStore", function () {
         ret.getPendingEvents = jest.fn().mockReturnValue([]);
         ret.isSpaceRoom = jest.fn().mockReturnValue(false);
         ret.getUnreadNotificationCount = jest.fn().mockReturnValue(numUnreads);
+        ret.getRoomUnreadNotificationCount = jest.fn().mockReturnValue(numUnreads);
         return ret;
     }
 });