Skip to content

improve error message missing mixin dep #478

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Dec 12, 2024
Merged

improve error message missing mixin dep #478

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
521adf9
improve error message missing mixin dep
gares Dec 12, 2024
9d592ee
Apply suggestions from code review
gares Dec 12, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion HB/common/synthesis.elpi
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -243,7 +243,7 @@ instantiate-all-these-mixin-args (fun _ Tm F) T ML R :-
factory-alias->gref TmGR M,
std.mem! ML M,
!,
mixin-for T M X, !,
if (mixin-for T M X) true (coq.error "Unable to find mixin" {nice-gref->string M} "on subject" {coq.term->string T}), !,
instantiate-all-these-mixin-args (F X) T ML R.
instantiate-all-these-mixin-args (fun N Ty F) T ML (fun N Ty FX) :- !,
@pi-decl N Ty m\ instantiate-all-these-mixin-args (F m) T ML (FX m).
Expand Down
3 changes: 2 additions & 1 deletion Makefile.test-suite.coq.local
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,4 +23,5 @@ post-all::
$(call DIFF, tests/howto.v)
$(call DIFF, tests/missing_join_error.v)
$(call DIFF, tests/not_same_key.v)
$(call DIFF, tests/hnf.v)
$(call DIFF, tests/hnf.v)
$(call DIFF, tests/err_miss_dep.v)
6 changes: 6 additions & 0 deletions tests/err_miss_dep.v
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
From HB Require Import structures.
HB.mixin Record IsAddComoid A := {}.
HB.structure Definition AddComoid := { A of IsAddComoid A }.
HB.mixin Record IsAbelianGrp A of IsAddComoid A := {}.
HB.structure Definition AbelianGrp := { A of IsAbelianGrp A }.
Fail HB.mixin Record IsRing K of IsAbelianGrp K (*& IsAddComoid K*) := {}.
2 changes: 2 additions & 0 deletions tests/err_miss_dep.v.out
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
The command has indeed failed with message:
Unable to find mixin err_miss_dep_IsAddComoid on subject K
Loading