optimize to use original arr array

k2s · k2s · commit 37cb66d18163 · 2020-05-31T12:00:44.000+02:00
diff --git a/js/datepicker.js b/js/datepicker.js
@@ -602,15 +602,14 @@
         j = 1 + year + opts.yearRange;
       }
 
-      let years = [];
       for (arr = []; i < j && i <= opts.maxYear; i++) {
         if (i >= opts.minYear) {
-          years.push(
-            `<option value="${i}" ${i === year ? 'selected="selected"' : ''}>${i}</option>`
-          );
+          arr.push(`<option value="${i}" ${i === year ? 'selected="selected"' : ''}>${i}</option>`);
         }
       }
-      arr = arr.concat(opts.yearRangeReverse ? years.reverse() : years);
+      if (opts.yearRangeReverse) {
+        arr.reverse();
+      }
 
       yearHtml = `<select class="datepicker-select orig-select-year" tabindex="-1">${arr.join(
         ''

Original file line number	Diff line number	Diff line change
`@@ -602,15 +602,14 @@`
`602`	`602`	`j = 1 + year + opts.yearRange;`
`603`	`603`	`}`
`604`	`604`
`605`		`- let years = [];`
`606`	`605`	`for (arr = []; i < j && i <= opts.maxYear; i++) {`
`607`	`606`	`if (i >= opts.minYear) {`
`608`		`- years.push(`
`609`		- `<option value="${i}" ${i === year ? 'selected="selected"' : ''}>${i}</option>`
`610`		`- );`
	`607`	+ arr.push(`<option value="${i}" ${i === year ? 'selected="selected"' : ''}>${i}</option>`);
`611`	`608`	`}`
`612`	`609`	`}`
`613`		`- arr = arr.concat(opts.yearRangeReverse ? years.reverse() : years);`
	`610`	`+ if (opts.yearRangeReverse) {`
	`611`	`+ arr.reverse();`
	`612`	`+ }`
`614`	`613`
`615`	`614`	yearHtml = `<select class="datepicker-select orig-select-year" tabindex="-1">${arr.join(
`616`	`615`	`''`