Skip to content

Commit ef5f643

Browse files
authored
🐛 FIX: pymatgen/numpy compilation issue (#70)
⬆️ UPGRADE: aiida-fleur 1.1.4 Earlier versions were pinning numpy to a lower version, causing conflicts with the pymatgen compilation which was built against a newer numpy version that was then forced to downgrade. Note, this issue is not identified by pip check! Also added a test for the pymatgen import
1 parent c7e85e4 commit ef5f643

File tree

2 files changed

+9
-1
lines changed

2 files changed

+9
-1
lines changed

defaults/main.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -92,7 +92,7 @@ aiida_plugins:
9292
code_prefix: cp2k
9393
codes_var: "cp2k_executables"
9494
aiida-fleur:
95-
version: "1.1.2"
95+
version: "1.1.4"
9696
code_prefix: fleur
9797
codes_var: "fleur_executables"
9898
aiida-nwchem:

molecule/default/verify.yml

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -38,6 +38,14 @@
3838
command: "{{ aiida_venv }}/bin/pip check --no-color"
3939
changed_when: false
4040

41+
# pymatgen can fail when the numpy it was compiled against is downgraded/upgraded
42+
# (e.g. due to a package pinning numpy)
43+
# ValueError: numpy.ndarray size changed, may indicate binary incompatibility. Expected 88 from C header, got 80 from PyObject
44+
# this is not identified by pip check!
45+
- name: test pymatgen import
46+
command: "{{ aiida_venv }}/bin/python -c 'import pymatgen'"
47+
changed_when: false
48+
4149
- name: is daemon running?
4250
command: "{{ aiida_venv }}/bin/verdi daemon status"
4351
changed_when: false

0 commit comments

Comments
 (0)