Skip to content

Commit 54d268d

Browse files
Do not clean up resources after execution
Revert voila-dashboards#969 This should never have been merged. The client still needs the kernel and channels running after execution ! Co-authored-by: davidbrochart <[email protected]>
1 parent a457763 commit 54d268d

File tree

1 file changed

+0
-8
lines changed

1 file changed

+0
-8
lines changed

voila/notebook_renderer.py

Lines changed: 0 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -244,8 +244,6 @@ async def _jinja_notebook_execute(self, nb, kernel_id):
244244
# (it seems to be local to our block)
245245
nb.cells = result.cells
246246

247-
await self._cleanup_resources()
248-
249247
async def _jinja_cell_generator(self, nb, kernel_id):
250248
"""Generator that will execute a single notebook cell at a time"""
251249
nb, _ = ClearOutputPreprocessor().preprocess(
@@ -295,12 +293,6 @@ async def _jinja_cell_generator(self, nb, kernel_id):
295293
finally:
296294
yield output_cell
297295

298-
await self._cleanup_resources()
299-
300-
async def _cleanup_resources(self):
301-
await ensure_async(self.executor.km.cleanup_resources())
302-
await ensure_async(self.executor.kc.stop_channels())
303-
304296
async def load_notebook(self, path):
305297
model = await ensure_async(self.contents_manager.get(path=path))
306298
if "content" not in model:

0 commit comments

Comments
 (0)