fix: move textarea normalization to pre-analyze

Author: DylanPiercey

.changeset/three-cobras-wonder.md

@@ -0,0 +1,5 @@
+---
+"@marko/runtime-tags": patch
+---
+
+Move textarea normalization to be pre-analyze.

packages/runtime-tags/src/translator/core/index.ts

@@ -22,7 +22,6 @@ import ScriptTag from "./script";
 import ServerTag from "./server";
 import StaticTag from "./static";
 import StyleTag from "./style";
-import TextAreaTag from "./textarea";
 import TitleTag from "./title";
 import TryTag from "./try";
 
@@ -53,7 +52,6 @@ export default {
   "<server>": ServerTag,
   "<static>": StaticTag,
   "<style>": StyleTag,
-  "<textarea>": TextAreaTag,
   "<title>": TitleTag,
   "<try>": TryTag,
 };

packages/runtime-tags/src/translator/core/script.ts

@@ -148,7 +148,6 @@ export default {
     text: true,
     preserveWhitespace: true,
   },
-  attributes: {},
   autocomplete: [
     {
       description: "Use to create a side effects.",

packages/runtime-tags/src/translator/core/textarea.ts

@@ -1,43 +1,31 @@
 import { types as t } from "@marko/compiler";
-import type { Tag } from "@marko/compiler/babel-utils";
 
 import normalizeStringExpression from "../util/normalize-string-expression";
 
-export default {
-  parse(tag) {
-    if (tag.node.body.body.length) {
-      // convert textarea body into a static value attribute.
-      const parts: (string | t.Expression)[] = [];
-      for (const child of tag.node.body.body) {
-        if (
-          child.type === "MarkoText" ||
-          (child.type === "MarkoPlaceholder" && child.escape)
-        ) {
-          parts.push(child.value);
-        } else {
-          throw tag.hub.file.hub.buildError(
-            child,
-            "Unexpected content in textarea, only text and placeholders are supported.",
-            SyntaxError,
-          );
-        }
+export function preAnalyze(tag: t.NodePath<t.MarkoTag>) {
+  if (tag.node.body.body.length) {
+    // convert textarea body into a static value attribute.
+    const parts: (string | t.Expression)[] = [];
+    for (const child of tag.node.body.body) {
+      if (
+        child.type === "MarkoText" ||
+        (child.type === "MarkoPlaceholder" && child.escape)
+      ) {
+        parts.push(child.value);
+      } else {
+        throw tag.hub.file.hub.buildError(
+          child,
+          "Unexpected content in textarea, only text and placeholders are supported.",
+          SyntaxError,
+        );
       }
-      tag.node.attributes.push(
-        t.markoAttribute(
-          "value",
-          normalizeStringExpression(parts) || buildUndefined(),
-        ),
-      );
+    }
 
-      tag.node.body.body = [];
+    const textValue = normalizeStringExpression(parts);
+    if (textValue) {
+      tag.node.attributes.push(t.markoAttribute("value", textValue));
     }
-  },
-  parseOptions: {
-    text: true,
-    preserveWhitespace: true,
-  },
-} as Tag;
 
-function buildUndefined() {
-  return t.unaryExpression("void", t.numericLiteral(0));
+    tag.node.body.body = [];
+  }
 }

packages/runtime-tags/src/translator/visitors/program/pre-analyze.ts

@@ -1,5 +1,6 @@
 import { types as t } from "@marko/compiler";
 
+import { preAnalyze as preAnalyzeTextarea } from "../../core/textarea";
 import { generateUid, generateUidIdentifier } from "../../util/generate-uid";
 import { getMarkoRoot, isMarko } from "../../util/get-root";
 import withPreviousLocation from "../../util/with-previous-location";
@@ -78,6 +79,12 @@ function normalizeTag(state: State, tag: t.NodePath<t.MarkoTag>) {
       // <MyTag> --> <${MyTag}>
       state.crawl = true;
       node.name = withPreviousLocation(t.identifier(tagName), name);
+    } else {
+      switch (tagName) {
+        case "textarea":
+          preAnalyzeTextarea(tag);
+          break;
+      }
     }
   }