perf: improve boot time by only traversing once

* refactor: only traverse once

The traverse module already recursively walks every node, this includes
nested objects and arrays. This makes the second traverse unnecessary and
increases the execution time significantly.

* refactor: skip enums and messages

By skipping objects with the key type, this should skip enums and
messages. Recursively iterating on enums and messages are unnecessary
and expensive as they contain the file descriptor protos which is a
buffer.

* refactor: remove usage of _.keys

* refactor: use single assignment to create object

* refactor: remove pick and reduce assignments

* docs: describe behaviour of call

Author: iszak

lib/app.js

@@ -99,7 +99,7 @@ class Mali extends Emitter {
     const data = mu.getServiceDefintions(proto)
 
     if (!name) {
-      name = _.keys(data)
+      name = Object.keys(data)
     } else if (_.isString(name)) {
       name = [name]
     }
@@ -190,7 +190,7 @@ class Mali extends Emitter {
       })
     } else if (_.isPlainObject(service)) {
       // we have object notation
-      const testKey = _.keys(service)[0]
+      const testKey = Object.keys(service)[0]
       if (_.isFunction(service[testKey]) || _.isArray(service[testKey])) {
         // first property of object is a function or array
         // that means we have service-level middleware of RPC handlers

lib/utils.js

@@ -37,36 +37,44 @@ function getCallTypeFromDescriptor (descriptor) {
 function getServiceDefintions (proto) {
   const services = {}
 
-  traverse(proto).forEach(function (v0) {
-    traverse(v0).forEach(function (v) {
-      if (isService(v)) {
-        const srviceObj = v.service || v
-        const vKeys = _.keys(srviceObj)
-        const name = getServiceNameFromPath(srviceObj[vKeys[0]].path)
-
-        if (services[name]) {
-          return
-        }
-
-        const shortServiceName = getShortServiceNameFromPath(srviceObj[vKeys[0]].path)
-
-        services[name] = {}
-        services[name].shortServiceName = shortServiceName
-        services[name].fullServiceName = name
-        services[name].service = srviceObj
-
-        const methods = {}
-        _.forOwn(srviceObj, (m, k) => {
-          methods[m.path] = _.pick(m, METHOD_PROPS)
-          methods[m.path].name = getMethodNameFromPath(m.path)
-          methods[m.path].fullName = m.path
-          methods[m.path].package = getPackageNameFromPath(m.path)
-          methods[m.path].service = shortServiceName
-        })
+  traverse(proto).forEach(function (v) {
+    if (isService(v)) {
+      const srviceObj = v.service || v
+      const vKeys = Object.keys(srviceObj)
+      const name = getServiceNameFromPath(srviceObj[vKeys[0]].path)
+
+      if (services[name]) {
+        return
+      }
 
-        services[name].methods = methods
+      const shortServiceName = getShortServiceNameFromPath(srviceObj[vKeys[0]].path)
+
+      services[name] = {
+        shortServiceName: shortServiceName,
+        fullServiceName: name,
+        service: srviceObj
       }
-    })
+
+      const methods = {}
+      _.forOwn(srviceObj, (m, k) => {
+        methods[m.path] = METHOD_PROPS.reduce((acc, method) => {
+          if (method !== 'name') {
+            acc[method] = m[method]
+          }
+          return acc
+        }, {
+          name: getMethodNameFromPath(m.path),
+          fullName: m.path,
+          package: getPackageNameFromPath(m.path),
+          service: shortServiceName
+        })
+      })
+
+      services[name].methods = methods
+    } else if (v && v.type) {
+      // Skip children
+      this.update(v, true)
+    }
   })
 
   return services
@@ -105,12 +113,12 @@ function getShortServiceNameFromPath (path) {
 
 function isService (v) {
   if (v && v.service) {
-    const vKeys = _.keys(v.service)
+    const vKeys = Object.keys(v.service)
 
     return vKeys && vKeys.length && v.service[vKeys[0]] && v.service[vKeys[0]].path &&
       _.isString(v.service[vKeys[0]].path) && v.service[vKeys[0]].path[0] === '/'
   } else if (v) {
-    const vKeys = _.keys(v)
+    const vKeys = Object.keys(v)
 
     return vKeys && vKeys.length && v[vKeys[0]] && v[vKeys[0]].path &&
       _.isString(v[vKeys[0]].path) && v[vKeys[0]].path[0] === '/'