Skip to content

FIx of Fatal Error: handleProductUpdated() Argument #2 ($post_after) must be of type WP (Issue #1309) #1310

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

FIx of Fatal Error: handleProductUpdated() Argument #2 ($post_after) must be of type WP (Issue #1309) #1310

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 7 additions & 2 deletions includes/class-mailchimp-woocommerce-service.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -367,8 +367,13 @@ public function handleAPICouponTrashed($object, $response, $request)
* @param WP_Post $post_before The post object as it exists after the update
* @return void
*/
public function handleProductUpdated( int $post_ID, WP_Post $post_after, WP_Post $post_before )
public function handleProductUpdated( int $post_ID, ?WP_Post $post_after, ?WP_Post $post_before )
{
// Ensure $post_after is a valid WP_Post
if ( ! $post_after instanceof WP_Post ) {
return;
}

if ('product' !== $post_after->post_type) {
return;
}
Expand All @@ -378,7 +383,7 @@ public function handleProductUpdated( int $post_ID, WP_Post $post_after, WP_Post
return;
}

/// old filter array('trash', 'auto-draft', 'draft', 'pending', 'private')
// 'draft', 'pending'
if (in_array($post_after->post_status, array('trash', 'auto-draft'))) {
mailchimp_log('product.update.blocked', "product {$post_ID} was blocked because status is {$post_after->post_status}");
return;
Expand Down