Set rpc cluster name as global window variable for walletAdapterLib #202
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GabrielePicco
approved these changes
Jan 28, 2024
GabrielePicco
requested changes
Jan 28, 2024
Runtime/Plugins/SolanaWalletAdapterWebGL/SolanaWalletAdapterWebGL.jslib
Outdated
Show resolved
Hide resolved
Collaborator
|
LGTM! Thanks @nicoeft |
GabrielePicco
approved these changes
Feb 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Include Solana Mobile Wallet Adapter for WebGL builds when running in mobile.
Solution
Most of the code containing the solution is in the unity-js-wallet-adapter where SolanaMobileWallet adapter instance is created when running in mobile. For that, we needed to pass the RPC cluser selected to the JS runtime. We just do that here, by setting a global variable window.rpcCluster with the cluster name from Unity thorugh jslib.
Deploy Notes
It's important to note that this PR alone does not provide the solution, it has a strict dependency on the PR for unity-js-wallet-adapter