Skip to content

Commit 3c6576a

Browse files
authored
Merge pull request #85 from macbre/check-version
tests: do not assume the version, silly me...
2 parents f6f6ff8 + 04af6be commit 3c6576a

File tree

4 files changed

+14
-5
lines changed

4 files changed

+14
-5
lines changed

README.md

Lines changed: 8 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -70,10 +70,10 @@ Visit <https://github.com/macbre/index-digest>
7070
```
7171
$ index_digest mysql://index_digest:qwerty@localhost/index_digest --sql-log sql/0002-not-used-indices-log
7272
------------------------------------------------------------
73-
Found 15 issue(s) to report for "index_digest" database
73+
Found 48 issue(s) to report for "index_digest" database
7474
------------------------------------------------------------
75-
MySQL v5.5.58-0+deb8u1 at debian
76-
index-digest v0.1.0
75+
MySQL v5.7.20 at debian
76+
index-digest v0.2.0
7777
------------------------------------------------------------
7878
redundant_indices → table affected: 0004_id_foo
7979
@@ -219,6 +219,11 @@ selects_with_like → table affected: 0020_big_table
219219
- query: SELECT * FROM 0020_big_table WHERE text LIKE '%00'
220220
- explain_extra: Using where
221221
- explain_rows: 100623
222+
223+
(...)
224+
225+
------------------------------------------------------------
226+
Queries performed: 100
222227
```
223228

224229
## SQL query log

indexdigest/test/formatters/test_plain.py

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -3,6 +3,7 @@
33

44
from unittest import TestCase
55

6+
from indexdigest import VERSION
67
from indexdigest.formatters import format_plain as formatter
78
from . import FormatterTestMixin
89

@@ -25,6 +26,7 @@ def test_format_plain(self):
2526

2627
assert 'Found 2 issue(s) to report for "test_database" database' in out
2728
assert 'MySQL v1.2.3-test at test.local' in out
29+
assert 'index-digest v' + VERSION in out
2830

2931
assert 'foo_linter → table affected: table_001' in out
3032
assert '✗ Something is fishy here' in out

indexdigest/test/formatters/test_syslog.py

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,6 @@
11
from unittest import TestCase
22

3+
from indexdigest import VERSION
34
from indexdigest.formatters.syslog import format_report
45
from . import FormatterTestMixin
56

@@ -12,7 +13,7 @@ def test_format_report_helper(self):
1213
print(out, report)
1314

1415
self.assertEquals(
15-
'{"meta": {"version": "index-digest v0.1.0", "database_name": "test_database", '
16+
'{"meta": {"version": "index-digest v' + VERSION + '", "database_name": "test_database", '
1617
'"database_host": "test.local", "database_version": "MySQL v1.2.3-test"}, '
1718
'"report": {"type": "foo_linter", "table": "table_001", "message": "Something is fishy here", '
1819
'"context": {"foo": 42, "test": "bar"}}}',

indexdigest/test/formatters/test_yaml.py

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,7 @@
22

33
from unittest import TestCase
44

5+
from indexdigest import VERSION
56
from indexdigest.formatters import format_yaml as formatter
67
from . import FormatterTestMixin
78

@@ -17,7 +18,7 @@ def test_formatter(self):
1718
assert 'meta' in res
1819
assert 'reports' in res
1920

20-
assert 'version: index-digest v0.1.0\n database_name: test_database\n' \
21+
assert 'version: index-digest v' + VERSION + '\n database_name: test_database\n' \
2122
' database_host: test.local\n database_version: MySQL v1.2.3-test' in out
2223

2324
assert 'message: Something is fishy here' in out

0 commit comments

Comments
 (0)