Skip to content

Commit 981904a

Browse files
committed
Merge branch 'notarytool'
2 parents 85ce337 + fdf00e0 commit 981904a

File tree

2 files changed

+21
-70
lines changed

2 files changed

+21
-70
lines changed

.github/workflows/release.yml

Lines changed: 21 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -33,7 +33,7 @@ jobs:
3333
asset_name: rswift-${{ github.event.release.tag_name }}-source.tar.gz
3434
asset_content_type: application/tar+gzip
3535

36-
- name: Build fat binary
36+
- name: Build universal binary
3737
run: |
3838
swift build -c release --arch x86_64 --arch arm64
3939
@@ -43,11 +43,13 @@ jobs:
4343
- name: Import Signing Certificates
4444
uses: apple-actions/import-codesign-certs@v1
4545
with:
46-
p12-file-base64: ${{ secrets.APPLE_CERTS }}
47-
p12-password: ${{ secrets.APPLE_CERTS_PASSWORD }}
46+
p12-file-base64: ${{ secrets.APPLE_CERTIFICATES }}
47+
p12-password: ${{ secrets.APPLE_CERTIFICATES_PASSWORD }}
4848
- name: Code Sign
4949
run: |
50-
codesign --force --options runtime --sign 'Developer ID Application: Mathijs Kadijk (5Z49PA849J)' .build/apple/Products/Release/rswift
50+
codesign --force --options runtime --sign "$IDENTITY" .build/apple/Products/Release/rswift
51+
env:
52+
IDENTITY: 'Developer ID Application: Nonstrict B.V. (WT5N9FK54M)'
5153
- name: Store build artifact
5254
uses: actions/upload-artifact@v3
5355
with:
@@ -60,12 +62,12 @@ jobs:
6062
FILENAME: ${{ runner.temp }}/rswift-${{ github.event.release.tag_name }}.zip
6163
- name: Notarize ZIP
6264
run: |
63-
sh notarize.sh
65+
xcrun notarytool submit $FILENAME --apple-id $APPLE_ID --password $APP_PASSWORD --team-id $TEAM_ID --wait
6466
env:
65-
BUNDLE_ID: nl.mathijskadijk.rswift
66-
DEV_ACCOUNT: ${{ secrets.APPLE_ID_EMAIL }}
67-
PASSWORD: ${{ secrets.APPLE_ID_PASSWORD }}
68-
DEV_TEAM: 5Z49PA849J
67+
BUNDLE_ID: com.nonstrict.rswift
68+
APPLE_ID: ${{ secrets.APPLE_IDENTIFIER }}
69+
APP_PASSWORD: ${{ secrets.APPLE_IDENTIFIER_PASSWORD }}
70+
TEAM_ID: WT5N9FK54M
6971
FILENAME: ${{ runner.temp }}/rswift-${{ github.event.release.tag_name }}.zip
7072
- name: Attach ZIP to release
7173
uses: actions/upload-release-asset@v1
@@ -89,21 +91,23 @@ jobs:
8991
run: |
9092
mkdir -p $PKG_ROOT/$BINARY_ROOT
9193
cp .build/apple/Products/Release/rswift $PKG_ROOT/$BINARY_ROOT
92-
pkgbuild --root $PKG_ROOT --identifier "nl.mathijskadijk.rswift" --version $TAG_NAME --install-location "/" --sign "Developer ID Installer: Mathijs Kadijk (5Z49PA849J)" $FILENAME
94+
pkgbuild --root $PKG_ROOT --identifier $BUNDLE_ID --version $TAG_NAME --install-location "/" --sign "$IDENTITY" $FILENAME
9395
env:
9496
TAG_NAME: ${{ github.event.release.tag_name }}
9597
FILENAME: ${{ runner.temp }}/rswift-${{ github.event.release.tag_name }}.pkg
96-
BUNDLE_ID: nl.mathijskadijk.rswift
98+
BUNDLE_ID: com.nonstrict.rswift
99+
IDENTITY: 'Developer ID Installer: Nonstrict B.V. (WT5N9FK54M)'
97100
PKG_ROOT: ${{ runner.temp }}/pkgroot
98101
BINARY_ROOT: /usr/local/bin
99102
- name: Notarize PKG
100103
run: |
101-
sh notarize.sh && xcrun stapler staple "$FILENAME"
104+
xcrun notarytool submit $FILENAME --apple-id $APPLE_ID --password $APP_PASSWORD --team-id $TEAM_ID --wait
105+
xcrun stapler staple $FILENAME
102106
env:
103-
BUNDLE_ID: nl.mathijskadijk.rswift
104-
DEV_ACCOUNT: ${{ secrets.APPLE_ID_EMAIL }}
105-
PASSWORD: ${{ secrets.APPLE_ID_PASSWORD }}
106-
DEV_TEAM: 5Z49PA849J
107+
BUNDLE_ID: com.nonstrict.rswift
108+
APPLE_ID: ${{ secrets.APPLE_IDENTIFIER }}
109+
APP_PASSWORD: ${{ secrets.APPLE_IDENTIFIER_PASSWORD }}
110+
TEAM_ID: WT5N9FK54M
107111
FILENAME: ${{ runner.temp }}/rswift-${{ github.event.release.tag_name }}.pkg
108112
- name: Attach PKG to release
109113
uses: actions/upload-release-asset@v1
@@ -117,3 +121,4 @@ jobs:
117121

118122
- name: Publish to Homebrew
119123
run: brew bump-formula-pr --tag $TAG_NAME --revision $REVISION rswift || exit 0
124+

notarize.sh

Lines changed: 0 additions & 54 deletions
This file was deleted.

0 commit comments

Comments
 (0)