feat: remove constraints from clones #139
Draft
+2
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anatawa12
commented
Nov 29, 2023
| public static readonly Type[] ShadowCloneComponentBlacklist = new Type[] { | ||
| typeof(Camera), typeof(FlareLayer), typeof(AudioSource), typeof(Light), typeof(ParticleSystemRenderer), typeof(Rigidbody), typeof(Joint) | ||
|
|
||
| typeof(Camera), typeof(FlareLayer), typeof(AudioSource), typeof(Light), typeof(ParticleSystemRenderer), typeof(Rigidbody), typeof(Joint), typeof(IConstraint), |
There was a problem hiding this comment.
I don't know much about shadow clone bit I assumed it's similar to mirror clone so I added constraint to this blacklist. is this correct?
|
I believe they re-added this, didn't they? |
|
Yes. VRChat rollbacked removing constraints for now. they says it will be added in the feature so I make this pull request draft for now and when they released again, I make ready for review again |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since Open Beta
1381, constraints are removed from mirrored avatars so I implemented this behavior.