Rebase of quarkusio#43396

* Offline test running (except for MY_CUSTOM_ENGINE)

Author: lucamolteni

docs/src/main/asciidoc/_attributes.adoc

@@ -54,6 +54,7 @@
 :quickstarts-tree-url: ${quickstarts-base-url}/tree/main
 // .
 :hibernate-orm-docs-url: https://docs.jboss.org/hibernate/orm/{hibernate-orm-version-major-minor}/userguide/html_single/Hibernate_User_Guide.html
+:hibernate-orm-javadocs-url: https://docs.jboss.org/hibernate/orm/{hibernate-orm-version-major-minor}/javadocs/
 :hibernate-orm-dialect-docs-url: https://docs.jboss.org/hibernate/orm/{hibernate-orm-version-major-minor}/dialect/dialect.html
 :hibernate-search-docs-url: https://docs.jboss.org/hibernate/search/{hibernate-search-version-major-minor}/reference/en-US/html_single/
 :hibernate-validator-docs-url: https://docs.jboss.org/hibernate/validator/{hibernate-validator-version-major-minor}/reference/en-US/html_single/

extensions/datasource/common/src/main/java/io/quarkus/datasource/common/runtime/DatabaseKind.java

@@ -97,7 +97,7 @@ public static boolean is(String value, String mainName) {
     private DatabaseKind() {
     }
 
-    private enum SupportedDatabaseKind {
+    public enum SupportedDatabaseKind {
         DB2(DatabaseKind.DB2),
         DERBY(DatabaseKind.DERBY),
         H2(DatabaseKind.H2),

extensions/hibernate-orm/deployment/src/main/java/io/quarkus/hibernate/orm/deployment/CockroachDialectConfig.java

@@ -0,0 +1,25 @@
+package io.quarkus.hibernate.orm.deployment;
+
+import java.util.Optional;
+
+import io.quarkus.runtime.annotations.ConfigGroup;
+import io.quarkus.runtime.configuration.TrimmedStringConverter;
+import io.smallrye.config.WithConverter;
+
+/**
+ * Configuration specific to the Hibernate ORM {@linkplain org.hibernate.dialect.CockroachDialect}
+ *
+ * @author Steve Ebersole
+ */
+@ConfigGroup
+public interface CockroachDialectConfig {
+    /**
+     * Specialized version string which can be passed into the {@linkplain org.hibernate.dialect.CockroachDialect}
+     */
+    @WithConverter(TrimmedStringConverter.class)
+    Optional<String> versionString();
+
+    default boolean isAnyPropertySet() {
+        return versionString().isPresent();
+    }
+}

extensions/hibernate-orm/deployment/src/main/java/io/quarkus/hibernate/orm/deployment/HANADialectConfig.java

@@ -0,0 +1,26 @@
+package io.quarkus.hibernate.orm.deployment;
+
+import java.util.Optional;
+
+import io.quarkus.runtime.annotations.ConfigDocDefault;
+import io.quarkus.runtime.annotations.ConfigGroup;
+
+/**
+ * Configuration specific to the Hibernate ORM {@linkplain org.hibernate.dialect.HANADialect}
+ *
+ * @author Steve Ebersole
+ */
+@ConfigGroup
+public interface HANADialectConfig {
+    /**
+     * Specifies the LOB prefetch size.
+     *
+     * @see org.hibernate.cfg.DialectSpecificSettings#HANA_MAX_LOB_PREFETCH_SIZE
+     */
+    @ConfigDocDefault("1024")
+    Optional<Integer> maxLobPrefetchSize();
+
+    default boolean isAnyPropertySet() {
+        return maxLobPrefetchSize().isPresent();
+    }
+}

extensions/hibernate-orm/deployment/src/main/java/io/quarkus/hibernate/orm/deployment/HibernateOrmConfigPersistenceUnit.java

@@ -304,12 +304,41 @@ interface HibernateOrmConfigPersistenceUnitDialect {
          *
          * E.g. `MyISAM` or `InnoDB` for MySQL.
          *
+         * @deprecated Use {@code mysql.}{@linkplain MySQLDialectConfig#storageEngine storage-engine}
+         *             or {@code mariadb.}{@linkplain MySQLDialectConfig#storageEngine storage-engine} instead
+         *
          * @asciidoclet
          */
-        Optional<@WithConverter(TrimmedStringConverter.class) String> storageEngine();
+        @WithConverter(TrimmedStringConverter.class)
+        @Deprecated
+        Optional<String> storageEngine();
+
+        /**
+         * Configuration specific to Hibernate's Dialect for MariaDB
+         */
+        MySQLDialectConfig mariadb();
+
+        /**
+         * Configuration specific to Hibernate's Dialect for MySQL
+         */
+        MySQLDialectConfig mysql();
+
+        /**
+         * Configuration specific to Hibernate's Dialect for Oracle
+         */
+        OracleDialectConfig oracle();
+
+        /**
+         * Configuration specific to Hibernate's Dialect for Microsoft SQLServer
+         */
+        SqlServerDialectConfig mssql();
 
         default boolean isAnyPropertySet() {
-            return dialect().isPresent() || storageEngine().isPresent();
+            return dialect().isPresent() || storageEngine().isPresent()
+                    || mysql().isAnyPropertySet()
+                    || oracle().isAnyPropertySet()
+                    || mssql().isAnyPropertySet()
+                    || mariadb().isAnyPropertySet();
         }
     }
 

extensions/hibernate-orm/deployment/src/main/java/io/quarkus/hibernate/orm/deployment/HibernateOrmProcessor.java

@@ -994,7 +994,10 @@ private static void collectDialectConfig(String persistenceUnitName,
             BuildProducer<ReflectiveMethodBuildItem> reflectiveMethods,
             BiConsumer<String, String> puPropertiesCollector,
             Set<String> storageEngineCollector) {
-        Optional<String> dialect = persistenceUnitConfig.dialect().dialect();
+        final HibernateOrmConfigPersistenceUnit.HibernateOrmConfigPersistenceUnitDialect dialectConfig = persistenceUnitConfig
+                .dialect();
+
+        Optional<String> dialect = dialectConfig.dialect();
         Optional<String> dbKind = jdbcDataSource.map(JdbcDataSourceBuildItem::getDbKind);
         Optional<String> explicitDbMinVersion = jdbcDataSource.flatMap(JdbcDataSourceBuildItem::getDbVersion);
         if (multiTenancyStrategy != MultiTenancyStrategy.DATABASE && jdbcDataSource.isEmpty()) {
@@ -1012,6 +1015,7 @@ private static void collectDialectConfig(String persistenceUnitName,
                 dbKind,
                 dialect,
                 explicitDbMinVersion,
+                dialectConfig,
                 dbKindMetadataBuildItems,
                 persistenceUnitConfig.dialect().storageEngine(),
                 systemProperties,

extensions/hibernate-orm/deployment/src/main/java/io/quarkus/hibernate/orm/deployment/MySQLDialectConfig.java

@@ -0,0 +1,46 @@
+package io.quarkus.hibernate.orm.deployment;
+
+import java.util.Optional;
+
+import io.quarkus.runtime.annotations.ConfigDocDefault;
+import io.quarkus.runtime.annotations.ConfigGroup;
+import io.quarkus.runtime.configuration.TrimmedStringConverter;
+import io.smallrye.config.WithConverter;
+
+/**
+ * Configuration specific to the Hibernate ORM {@linkplain org.hibernate.dialect.MySQLDialect},
+ * though may also affect other dialects such as {@linkplain org.hibernate.dialect.MariaDBDialect}.
+ *
+ * @author Steve Ebersole
+ */
+@ConfigGroup
+public interface MySQLDialectConfig {
+    /**
+     * Specifies the bytes per character to use based on the database's configured
+     * <a href="https://dev.mysql.com/doc/refman/8.0/en/charset-charsets.html">charset</a>.
+     *
+     * @see org.hibernate.cfg.DialectSpecificSettings#MYSQL_BYTES_PER_CHARACTER
+     */
+    @ConfigDocDefault("4")
+    Optional<Integer> bytesPerCharacter();
+
+    /**
+     * Specifies whether the {@code NO_BACKSLASH_ESCAPES} sql mode is enabled.
+     *
+     * @see org.hibernate.cfg.DialectSpecificSettings#MYSQL_NO_BACKSLASH_ESCAPES
+     */
+    @ConfigDocDefault("false")
+    Optional<Boolean> noBackslashEscapes();
+
+    /**
+     * The storage engine to use.
+     */
+    @WithConverter(TrimmedStringConverter.class)
+    Optional<String> storageEngine();
+
+    default boolean isAnyPropertySet() {
+        return bytesPerCharacter().isPresent()
+                || noBackslashEscapes().isPresent()
+                || storageEngine().isPresent();
+    }
+}

extensions/hibernate-orm/deployment/src/main/java/io/quarkus/hibernate/orm/deployment/OracleDialectConfig.java

@@ -0,0 +1,45 @@
+package io.quarkus.hibernate.orm.deployment;
+
+import java.util.Optional;
+
+import io.quarkus.runtime.annotations.ConfigDocDefault;
+import io.quarkus.runtime.annotations.ConfigGroup;
+
+/**
+ * Configuration specific to the Hibernate ORM {@linkplain org.hibernate.dialect.OracleDialect}
+ *
+ * @author Steve Ebersole
+ */
+@ConfigGroup
+public interface OracleDialectConfig {
+
+    /**
+     * Support for Oracle's MAX_STRING_SIZE = EXTENDED.
+     *
+     * @see org.hibernate.cfg.DialectSpecificSettings#ORACLE_EXTENDED_STRING_SIZE
+     */
+    @ConfigDocDefault("false")
+    Optional<Boolean> extended();
+
+    /**
+     * Specifies whether this database is running on an Autonomous Database Cloud Service.
+     *
+     * @see org.hibernate.cfg.DialectSpecificSettings#ORACLE_AUTONOMOUS_DATABASE
+     */
+    @ConfigDocDefault("false")
+    Optional<Boolean> autonomous();
+
+    /**
+     * Specifies whether this database is accessed using a database service protected by Application Continuity.
+     *
+     * @see org.hibernate.cfg.DialectSpecificSettings#ORACLE_APPLICATION_CONTINUITY
+     */
+    @ConfigDocDefault("false")
+    Optional<Boolean> applicationContinuity();
+
+    default boolean isAnyPropertySet() {
+        return extended().isPresent()
+                || autonomous().isPresent()
+                || applicationContinuity().isPresent();
+    }
+}

extensions/hibernate-orm/deployment/src/main/java/io/quarkus/hibernate/orm/deployment/SqlServerDialectConfig.java

@@ -0,0 +1,27 @@
+package io.quarkus.hibernate.orm.deployment;
+
+import java.util.Optional;
+
+import io.quarkus.runtime.annotations.ConfigGroup;
+import io.quarkus.runtime.configuration.TrimmedStringConverter;
+import io.smallrye.config.WithConverter;
+
+/**
+ * Configuration specific to the Hibernate ORM {@linkplain org.hibernate.dialect.SQLServerDialect}
+ *
+ * @author Steve Ebersole
+ */
+@ConfigGroup
+public interface SqlServerDialectConfig {
+    /**
+     * The {@code compatibility_level} as defined in {@code sys.databases}.
+     *
+     * @see org.hibernate.cfg.DialectSpecificSettings#SQL_SERVER_COMPATIBILITY_LEVEL
+     */
+    @WithConverter(TrimmedStringConverter.class)
+    Optional<String> compatibilityLevel();
+
+    default boolean isAnyPropertySet() {
+        return compatibilityLevel().isPresent();
+    }
+}

extensions/hibernate-orm/deployment/src/main/java/io/quarkus/hibernate/orm/deployment/SybaseDialectConfig.java

@@ -0,0 +1,28 @@
+package io.quarkus.hibernate.orm.deployment;
+
+import java.util.Optional;
+
+import io.quarkus.runtime.annotations.ConfigDocDefault;
+import io.quarkus.runtime.annotations.ConfigGroup;
+
+/**
+ * Configuration specific to the Hibernate ORM {@linkplain org.hibernate.dialect.SybaseDialect}
+ *
+ * @author Steve Ebersole
+ */
+@ConfigGroup
+public interface SybaseDialectConfig {
+
+    /**
+     * Whether the database's {@code ansinull} setting is enabled
+     *
+     * @see org.hibernate.cfg.DialectSpecificSettings#SYBASE_ANSI_NULL
+     */
+    @SuppressWarnings("SpellCheckingInspection")
+    @ConfigDocDefault("false")
+    Optional<Boolean> ansinull();
+
+    default boolean isAnyPropertySet() {
+        return ansinull().isPresent();
+    }
+}