Skip to content

Commit 8a5bdfd

Browse files
lpahlavialtkdf
andauthored
chore(crypto): CRP-2692 Move ed25519 crate to packages (dfinity#3770)
([CRP-2692](https://dfinity.atlassian.net/browse/CRP-2692)) Move the ic-crypto-ed25519 crate to ic/packages and rename it to ic-ed25519 so it can be published on [crates.io](https://crates.io/). [CRP-2692]: https://dfinity.atlassian.net/browse/CRP-2692?atlOrigin=eyJpIjoiNWRkNTljNzYxNjVmNDY3MDlhMDU5Y2ZhYzA5YTRkZjUiLCJwIjoiZ2l0aHViLWNvbS1KU1cifQ --------- Co-authored-by: Oleksandr Tkachenko <[email protected]>
1 parent 152a69a commit 8a5bdfd

File tree

65 files changed

+148
-135
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

65 files changed

+148
-135
lines changed

.github/CODEOWNERS

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -49,6 +49,7 @@ go_deps.bzl @dfinity/idx
4949
/packages/icrc-ledger-types/ @dfinity/finint
5050
/packages/ic-ledger-hash-of/ @dfinity/finint
5151
/packages/pocket-ic/ @dfinity/pocket-ic
52+
/packages/ic-ed25519/ @dfinity/crypto-team
5253
/packages/ic-ethereum-types/ @dfinity/cross-chain-team
5354
/packages/ic-metrics-assert/ @dfinity/cross-chain-team
5455
/packages/ic-sha3/ @dfinity/crypto-team

Cargo.lock

Lines changed: 34 additions & 34 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

Cargo.toml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,6 +6,7 @@ members = [
66
"packages/icrc-ledger-client",
77
"packages/icrc-ledger-client-cdk",
88
"packages/icrc-ledger-types",
9+
"packages/ic-ed25519",
910
"packages/ic-ethereum-types",
1011
"packages/ic-metrics-assert",
1112
"packages/ic-sha3",
@@ -65,7 +66,6 @@ members = [
6566
"rs/criterion_time",
6667
"rs/crypto",
6768
"rs/crypto/ecdsa_secp256r1",
68-
"rs/crypto/ed25519",
6969
"rs/crypto/for_verification_only",
7070
"rs/crypto/iccsa",
7171
"rs/crypto/internal/crypto_lib/basic_sig/der_utils",

rs/crypto/ed25519/BUILD.bazel renamed to packages/ic-ed25519/BUILD.bazel

Lines changed: 15 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
load("@rules_rust//rust:defs.bzl", "rust_doc", "rust_library", "rust_test", "rust_test_suite")
1+
load("@rules_rust//rust:defs.bzl", "rust_doc", "rust_doc_test", "rust_library", "rust_test", "rust_test_suite")
22

33
package(default_visibility = ["//visibility:public"])
44

@@ -28,33 +28,39 @@ MACRO_DEV_DEPENDENCIES = []
2828
ALIASES = {}
2929

3030
rust_library(
31-
name = "ed25519",
31+
name = "ic-ed25519",
3232
srcs = glob(["src/**/*.rs"]),
3333
aliases = ALIASES,
34-
crate_name = "ic_crypto_ed25519",
34+
crate_name = "ic_ed25519",
3535
proc_macro_deps = MACRO_DEPENDENCIES,
3636
version = "0.9.0",
3737
deps = DEPENDENCIES,
3838
)
3939

4040
rust_doc(
41-
name = "ed25519_doc",
42-
crate = ":ed25519",
41+
name = "doc",
42+
crate = ":ic-ed25519",
43+
)
44+
45+
rust_doc_test(
46+
name = "doc_test",
47+
crate = ":ic-ed25519",
48+
deps = [":ic-ed25519"] + DEPENDENCIES + DEV_DEPENDENCIES,
4349
)
4450

4551
rust_test(
46-
name = "ed25519_test",
52+
name = "test",
4753
aliases = ALIASES,
48-
crate = ":ed25519",
54+
crate = ":ic-ed25519",
4955
proc_macro_deps = MACRO_DEPENDENCIES + MACRO_DEV_DEPENDENCIES,
5056
deps = DEPENDENCIES + DEV_DEPENDENCIES,
5157
)
5258

5359
rust_test_suite(
54-
name = "ed25519_integration",
60+
name = "integration_tests",
5561
srcs = glob(["tests/**/*.rs"]),
5662
aliases = ALIASES,
5763
compile_data = glob(["tests/data/*"]),
5864
proc_macro_deps = MACRO_DEPENDENCIES + MACRO_DEV_DEPENDENCIES,
59-
deps = [":ed25519"] + DEPENDENCIES + DEV_DEPENDENCIES,
65+
deps = [":ic-ed25519"] + DEPENDENCIES + DEV_DEPENDENCIES,
6066
)

packages/ic-ed25519/CHANGELOG.md

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,8 @@
1+
# Changelog
2+
3+
All notable changes to this project will be documented in this file.
4+
5+
The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/),
6+
and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html).
7+
8+
## [Unreleased]

rs/crypto/ed25519/Cargo.toml renamed to packages/ic-ed25519/Cargo.toml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
[package]
2-
name = "ic-crypto-ed25519"
2+
name = "ic-ed25519"
33
version.workspace = true
44
authors.workspace = true
55
edition.workspace = true

packages/ic-ed25519/LICENSE

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1 @@
1+
../../licenses/Apache-2.0.txt

packages/ic-ed25519/README.md

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,3 @@
1+
# IC Ed25519
2+
3+
A package created for the Internet Computer Protocol for creating and verifying Ed25519 signatures.
File renamed without changes.
File renamed without changes.

0 commit comments

Comments
 (0)