Skip to content

Commit 0fe05a2

Browse files
authored
fix(nervous-system): release runscript doesn't prompt you to update mainnet-canisters.json (dfinity#3792)
The release runscript doesn't need to prompt you to update mainnet-canisters.json since PRs to do so are created automatically now, for example in dfinity#3727. We still need to remember to merge the automatically-created PR, but hopefully that will be pretty easy [← Previous PR](dfinity#3791) | [Next PR →](dfinity#3793)
1 parent 1f2dda0 commit 0fe05a2

File tree

1 file changed

+2
-32
lines changed
  • rs/nervous_system/tools/release-runscript/src

1 file changed

+2
-32
lines changed

rs/nervous_system/tools/release-runscript/src/main.rs

Lines changed: 2 additions & 32 deletions
Original file line numberDiff line numberDiff line change
@@ -59,9 +59,6 @@ struct ScheduleVote {
5959
sns_proposal_ids: Vec<String>,
6060
}
6161

62-
#[derive(Debug, Parser)]
63-
struct UpdateCanistersJson;
64-
6562
#[derive(Debug, Parser)]
6663
struct UpdateChangelog;
6764

@@ -81,9 +78,7 @@ enum Step {
8178
CreateForumPost(CreateForumPost),
8279
#[command(about = "Step 7: Schedule Trusted Neurons Vote")]
8380
ScheduleVote(ScheduleVote),
84-
#[command(about = "Step 8: Update Mainnet Canisters")]
85-
UpdateCanistersJson(UpdateCanistersJson),
86-
#[command(about = "Step 9: Update Changelog")]
81+
#[command(about = "Step 8: Update Changelog")]
8782
UpdateChangelog(UpdateChangelog),
8883
}
8984

@@ -122,7 +117,6 @@ fn main() -> Result<()> {
122117
Some(Step::SubmitProposals(cmd)) => run_submit_proposals(cmd),
123118
Some(Step::CreateForumPost(cmd)) => run_create_forum_post(cmd),
124119
Some(Step::ScheduleVote(cmd)) => run_schedule_vote(cmd),
125-
Some(Step::UpdateCanistersJson(cmd)) => run_update_canisters_json(cmd),
126120
Some(Step::UpdateChangelog(cmd)) => run_update_changelog(cmd),
127121
}
128122

@@ -687,36 +681,12 @@ Calendar Event Setup:
687681
- If people don't respond, ping @trusted-neurons in #eng-release channel",
688682
);
689683

690-
run_update_canisters_json(UpdateCanistersJson);
691-
}
692-
693-
fn run_update_canisters_json(_: UpdateCanistersJson) {
694-
print_step(
695-
8,
696-
"Update Mainnet Canisters",
697-
"After proposal execution, update mainnet-canisters.json:
698-
699-
1. Run the sync command:
700-
bazel run //rs/nervous_system/tools/sync-with-released-nevous-system-wasms
701-
702-
Note: If you encounter problems, try adding --config=local
703-
704-
2. Purpose of these changes:
705-
- Tells bazel what versions are running in production
706-
- Used by tests to verify upgrade compatibility
707-
- Maintains build hermeticity
708-
709-
3. Note on automation:
710-
- There was a ticket for automating this (NNS1-2201)
711-
- Currently marked as won't do",
712-
);
713-
714684
run_update_changelog(UpdateChangelog);
715685
}
716686

717687
fn run_update_changelog(_: UpdateChangelog) {
718688
print_step(
719-
9,
689+
8,
720690
"Update Changelog",
721691
"Update CHANGELOG.md file(s) for each proposal:
722692

0 commit comments

Comments
 (0)