Include URL in response error message

[nielsbuus]

I was wondering if Faraday has intentionally been designed to omit the request url in the Faraday error messages or if that is just a coincidence.

I often find myself wanting to know which URL is failing when I see a Faraday exception in my logs.

I could make a pull request around this area of the code if you are open the idea of including the URL in the error message.

What do you think?

[iMacTia]

Hi @nielsbuus, the response object should contain information about the request too, do you have a snippet to share that shows when that might not be the case?

[nielsbuus]

Thank you @iMacTia - would you like me to prepare a pull request for the improvement / feature? Are there any security considerations to including the full URL in the error message, which may include tokens or other sensitive information?

[iMacTia]

The URL shouldn't really contain any sensitive information these days, but I can see some old applications might still rely on basic authentication or similar. It might be a good idea to parse the URI and strip those out if present by only selecting the protocol, hostname and path. Query string might contain sensitive data too but I'd consider that negligence, so it should be fine to log these too

[iMacTia]

And yes I'd very much welcome a thoughtful PR for this improvement 🙏

[nielsbuus]

For future reference, a merge request about this functionality has been opened here #1628 😃

[iMacTia]

Merged and released 🎉
https://github.com/lostisland/faraday/releases/tag/v2.13.2

Thank you again for raising this @nielsbuus

[iMacTia]

Closing as this was released in v2.13.2 🙌
https://github.com/lostisland/faraday/releases/tag/v2.13.2