Skip to content

Commit ef9eeb1

Browse files
committed
build: remove the reset of corepack
Refs: - nodejs/TSC#1697 (comment) - nodejs#57617
1 parent 538186b commit ef9eeb1

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

68 files changed

+0
-25574
lines changed

.gitattributes

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,5 @@ test/fixtures/* -text
22
vcbuild.bat text eol=crlf
33
deps/npm/bin/npm text eol=lf
44
deps/npm/bin/npx text eol=lf
5-
deps/corepack/shims/corepack text eol=lf
65
tools/msvs/find_python.cmd text eol=crlf
76
doc/**/*.md text eol=lf

.github/workflows/tools.yml

Lines changed: 0 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,6 @@ on:
2020
- brotli
2121
- c-ares
2222
- cjs-module-lexer
23-
- corepack
2423
- doc
2524
- googletest
2625
- gyp-next
@@ -112,12 +111,6 @@ jobs:
112111
cat temp-output
113112
tail -n1 temp-output | grep "NEW_VERSION=" >> "$GITHUB_ENV" || true
114113
rm temp-output
115-
- id: corepack
116-
subsystem: deps
117-
label: dependencies
118-
run: |
119-
make corepack-update
120-
echo "NEW_VERSION=$(node deps/corepack/dist/corepack.js --version)" >> $GITHUB_ENV
121114
- id: doc
122115
subsystem: tools
123116
label: tools

.gitignore

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -63,7 +63,6 @@ _UpgradeReport_Files/
6363
*.wixobj
6464
/tools/msvs/genfiles/
6565
/npm.wxs
66-
/corepack.wxs
6766
/tools/msvs/msi/**/Release/
6867
/tools/msvs/msi/**/obj/
6968
/tools/msvs/msi/**/x64/

LICENSE

Lines changed: 0 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -986,17 +986,6 @@ The externally maintained libraries used by Node.js are:
986986
USE OR OTHER DEALINGS IN THE SOFTWARE.
987987
"""
988988

989-
- corepack, located at deps/corepack, is licensed as follows:
990-
"""
991-
**Copyright © Corepack contributors**
992-
993-
Permission is hereby granted, free of charge, to any person obtaining a copy of this software and associated documentation files (the "Software"), to deal in the Software without restriction, including without limitation the rights to use, copy, modify, merge, publish, distribute, sublicense, and/or sell copies of the Software, and to permit persons to whom the Software is furnished to do so, subject to the following conditions:
994-
995-
The above copyright notice and this permission notice shall be included in all copies or substantial portions of the Software.
996-
997-
THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE SOFTWARE.
998-
"""
999-
1000989
- undici, located at deps/undici, is licensed as follows:
1001990
"""
1002991
MIT License

Makefile

Lines changed: 0 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -1184,18 +1184,6 @@ endif
11841184
.PHONY: pkg
11851185
pkg: $(PKG) ## Build the macOS installer for releases.
11861186

1187-
.PHONY: corepack-update
1188-
corepack-update: ## Update Corepack to the latest version.
1189-
mkdir -p /tmp/node-corepack
1190-
curl -qLo /tmp/node-corepack/package.tgz "$$($(call available-node,$(NPM) view corepack dist.tarball))"
1191-
1192-
rm -rf deps/corepack && mkdir deps/corepack
1193-
cd deps/corepack && tar xf /tmp/node-corepack/package.tgz --strip-components=1
1194-
chmod +x deps/corepack/shims/*
1195-
1196-
$(call available-node,'-p' \
1197-
'require(`./deps/corepack/package.json`).version')
1198-
11991187
.PHONY: pkg-upload
12001188
# Note: this is strictly for release builds on release machines only.
12011189
pkg-upload: pkg

SECURITY.md

Lines changed: 0 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -275,13 +275,6 @@ the community they pose.
275275
that artifact is large enough to impact performance or
276276
cause the runtime to run out of resources.
277277

278-
#### Vulnerabilities affecting software downloaded by Corepack
279-
280-
* Corepack defaults to downloading the latest version of the software requested
281-
by the user, or a specific version requested by the user. For this reason,
282-
Node.js releases won't be affected by such vulnerabilities. Users are
283-
responsible for keeping the software they use through Corepack up-to-date.
284-
285278
## Assessing experimental features reports
286279

287280
Experimental features are eligible for security reports just like any other

benchmark/misc/startup-cli-version.js

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,6 @@ const availableCli = [
1414
'tools/eslint/node_modules/eslint/bin/eslint.js',
1515
'deps/npm/bin/npx-cli.js',
1616
'deps/npm/bin/npm-cli.js',
17-
'deps/corepack/dist/corepack.js',
1817
].filter((cli) => existsSync(path.resolve(__dirname, '../../', cli)));
1918
const bench = common.createBenchmark(main, {
2019
cli: availableCli,

configure.py

Lines changed: 0 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -807,12 +807,6 @@
807807
default=None,
808808
help='do not install the bundled npm (package manager)')
809809

810-
parser.add_argument('--with-corepack',
811-
action='store_true',
812-
dest='with_corepack',
813-
default=None,
814-
help='do install the bundled Corepack (experimental, will be removed without notice)')
815-
816810
parser.add_argument('--control-flow-guard',
817811
action='store_true',
818812
dest='enable_cfg',
@@ -1512,7 +1506,6 @@ def configure_node(o):
15121506
o['variables']['OS'] = 'android'
15131507
o['variables']['node_prefix'] = options.prefix
15141508
o['variables']['node_install_npm'] = b(not options.without_npm)
1515-
o['variables']['node_install_corepack'] = b(options.with_corepack)
15161509
o['variables']['control_flow_guard'] = b(options.enable_cfg)
15171510
o['variables']['node_use_amaro'] = b(not options.without_amaro)
15181511
o['variables']['debug_node'] = b(options.debug_node)

0 commit comments

Comments
 (0)