Skip to content

Commit 0b460e0

Browse files
authored
Remove the SDL2 example (#886)
If someone cares to work out why it doesn't compile and then brings it back, then they can do. But I don't care to, and we need CI to be working.
1 parent 61f82e4 commit 0b460e0

File tree

4 files changed

+6
-53
lines changed

4 files changed

+6
-53
lines changed

.github/workflows/ci.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,7 @@ env:
1919
FEATURES_DEPENDING_ON_STD: "std,default"
2020
# List of packages that can not target Wasm.
2121
# `vello_tests` uses `nv-flip`, which doesn't support Wasm.
22-
NO_WASM_PKGS: "--exclude vello_tests --exclude simple_sdl2"
22+
NO_WASM_PKGS: "--exclude vello_tests"
2323
# The files stored in LFS the tests need to access, in JSON format
2424
LFS_FILES: '["vello_tests/snapshots/*.png", "sparse_strips/vello_cpu/snapshots/*.png"]'
2525

CHANGELOG.md

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -29,6 +29,9 @@ This release has an [MSRV][] of 1.85.
2929

3030
The crates were switched to edition 2024 of Rust.
3131

32+
- The example which uses sdl2 has been removed.
33+
The sdl2 crates no longer compile, and this example previously existing shows that it was possible. ([#886][] by [@DJMcNab][])
34+
3235
## [0.4.1][] - 2025-03-10
3336

3437
This release has an [MSRV][] of 1.82.
@@ -257,6 +260,7 @@ This release has an [MSRV][] of 1.75.
257260
[#796]: https://github.com/linebender/vello/pull/796
258261
[#803]: https://github.com/linebender/vello/pull/803
259262
[#841]: https://github.com/linebender/vello/pull/841
263+
[#886]: https://github.com/linebender/vello/pull/886
260264

261265
<!-- Note that this still comparing against 0.4.0, because 0.4.1 is a cherry-picked patch -->
262266
[Unreleased]: https://github.com/linebender/vello/compare/v0.4.0...HEAD

Cargo.lock

Lines changed: 0 additions & 49 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

Cargo.toml

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,6 @@ members = [
1010
"examples/run_wasm",
1111
"examples/scenes",
1212
"examples/simple",
13-
"examples/simple_sdl2",
1413
"examples/with_winit",
1514

1615
"sparse_strips/vello_api",
@@ -28,8 +27,7 @@ members = [
2827
#
2928
# NOTE: When bumping this, remember to also bump the aforementioned other packages'
3029
# version in the dependencies section at the bottom of this file.
31-
# Additionally, bump the Vello dependency version in the 'simple'
32-
# and `simple_sdl2` examples.
30+
# Additionally, bump the Vello dependency version in the 'simple' example.
3331
version = "0.4.0"
3432

3533
edition = "2024"

0 commit comments

Comments
 (0)