f Fix parsing for Bolt11 and Bolt12 payments in URI

Updated in `unifed_qr.rs`:
   - I updated `deserialize_temp` to handle different network
     prefixes for Bolt11 invoices (lnbc, lntb, lnbcrt, lnsb)
     and Bolt12 offers (lno).
   - Added parsing logic based on the mentioned prefixes.
   - Ensured that both Bolt11 and Bolt12 payment tests pass
     correctly.

Test:
   - Verified that `unified_qr_send_receive` handled Bolt11
     invoices and Bolt12 offers correctly.
   - Added Bolt12 offer to URI and had a successful payment
     sent.
   - Then added a fallback Bolt11 payment that was successful
   - Tested node_b to verify it received both lighting payments.

Author: slanesuke

src/payment/unified_qr.rs

@@ -214,13 +214,19 @@ impl<'a> bip21::de::DeserializationState<'a> for DeserializationState {
 		if key == "lightning" {
 			let lighting_str = String::try_from(value).map_err(|_| Error::UriParameterFailed)?;
 
-			for part in lighting_str.split('&') {
-				if part.starts_with("LN") || part.starts_with("ln") {
+			for prefix in lighting_str.split('&') {
+				let prefix_lowercase = prefix.to_lowercase();
+
+				if prefix_lowercase.starts_with("lnbc")
+					|| prefix_lowercase.starts_with("lntb")
+					|| prefix_lowercase.starts_with("lnbcrt")
+					|| prefix_lowercase.starts_with("lnsb")
+				{
 					let invoice =
-						part.parse::<Bolt11Invoice>().map_err(|_| Error::InvalidInvoice)?;
+						prefix.parse::<Bolt11Invoice>().map_err(|_| Error::InvalidInvoice)?;
 					self.bolt11_invoice = Some(invoice)
-				} else if part.starts_with("LNO") || part.starts_with("lno") {
-					let offer = part.parse::<Offer>().map_err(|_| Error::InvalidOffer)?;
+				} else if prefix_lowercase.starts_with("lno") {
+					let offer = prefix.parse::<Offer>().map_err(|_| Error::InvalidOffer)?;
 					self.bolt12_offer = Some(offer)
 				}
 			}

tests/integration_tests_rust.rs

@@ -584,45 +584,58 @@ fn unified_qr_send_receive() {
 	// Sleep one more sec to make sure the node announcement propagates.
 	std::thread::sleep(std::time::Duration::from_secs(1));
 
-	let expected_lightning_amount_sats = 100_000;
+	let expected_amount_msats = 100_000_000;
+	let offer = node_b.bolt12_payment().receive(expected_amount_msats, "hi");
+
+	let offer_str = offer.clone().unwrap().to_string();
+	let bolt12_offer_param = format!("&lightning={}", offer_str);
+
+	let expected_amount_sats = 100_000;
 	let message = "TestMessage".to_string();
 	let expiry_sec = 4_000;
 
-	let uqr_payment = node_b.unified_qr_payment().receive(
-		expected_lightning_amount_sats,
-		Some(message),
-		expiry_sec,
-	);
-
-	match uqr_payment {
-		Ok(ref uri) => {
-			assert!(uri.contains("BITCOIN:"));
-			assert!(uri.contains("lightning"));
-			println!("\nGenerated URI: {}", uri);
-		},
-		Err(e) => panic!("Failed to generate URI: {:?}", e),
-	}
+	let uqr_payment =
+		node_b.unified_qr_payment().receive(expected_amount_sats, Some(message), expiry_sec);
 
 	let uri_str = uqr_payment.clone().unwrap();
+	let uri_with_offer = format!("{}{}", uri_str, bolt12_offer_param);
 
-	match node_a.unified_qr_payment().send(&uri_str) {
+	let offer_payment_id: PaymentId = match node_a.unified_qr_payment().send(&uri_with_offer) {
 		Ok(PaymentResult::Bolt12 { payment_id }) => {
-			println!("Bolt12 Payment sent successfully with PaymentID: {:?}", payment_id);
+			println!("\nBolt12 payment sent successfully with PaymentID: {:?}", payment_id);
+			payment_id
 		},
-		Ok(PaymentResult::Bolt11 { payment_id }) => {
-			println!("Bolt11 payment sent successfully with PaymentID: {:?}", payment_id);
+		Ok(PaymentResult::Bolt11 { payment_id: _ }) => {
+			panic!("Expected Bolt12 payment but got Bolt11");
 		},
-		Ok(PaymentResult::Onchain { txid }) => {
-			println!("Onchain payment sent successfully with Txid: {:?}", txid);
-			wait_for_tx(&electrsd.client, txid);
+		Ok(PaymentResult::Onchain { txid: _ }) => {
+			panic!("Expected Bolt12 payment but get On-chain transaction");
 		},
 		Err(e) => {
-			println!("Failed to send payment using the URI: {:?}", e);
+			panic!("Expected Bolt12 payment but got error: {:?}", e);
 		},
-	}
+	};
 
-	let payment_id = expect_payment_received_event!(node_b, expected_lightning_amount_sats * 1_000);
-	expect_payment_successful_event!(node_a, payment_id, None);
+	expect_payment_successful_event!(node_a, Some(offer_payment_id), None);
+
+	let uri_with_invalid_offer = format!("{}{}", uri_str, "&lightning=some_invalid_offer");
+	let invoice_payment_id: PaymentId =
+		match node_a.unified_qr_payment().send(&uri_with_invalid_offer) {
+			Ok(PaymentResult::Bolt12 { payment_id: _ }) => {
+				panic!("Expected Bolt11 payment but got Bolt12");
+			},
+			Ok(PaymentResult::Bolt11 { payment_id }) => {
+				println!("\nBolt11 payment sent successfully with PaymentID: {:?}", payment_id);
+				payment_id
+			},
+			Ok(PaymentResult::Onchain { txid: _ }) => {
+				panic!("Expected Bolt11 payment but got on-chain transaction");
+			},
+			Err(e) => {
+				panic!("Expected Bolt11 payment but got error: {:?}", e);
+			},
+		};
+	expect_payment_successful_event!(node_a, Some(invoice_payment_id), None);
 
 	let expect_onchain_amount_sats = 800_000;
 	let onchain_uqr_payment = node_b
@@ -631,21 +644,18 @@ fn unified_qr_send_receive() {
 		.unwrap();
 
 	let txid = match node_a.unified_qr_payment().send(onchain_uqr_payment.as_str()) {
-		Ok(PaymentResult::Bolt12 { payment_id }) => {
-			println!("Bolt12 Payment sent successfully with PaymentID: {:?}", payment_id);
-			panic!("Expected on-chain payment but got Bolt12 payment")
+		Ok(PaymentResult::Bolt12 { payment_id: _ }) => {
+			panic!("Expected on-chain payment but got Bolt12")
 		},
-		Ok(PaymentResult::Bolt11 { payment_id }) => {
-			println!("Bolt11 invoice sent successfully with PaymentId: {}", payment_id);
-			panic!("Expected on-chain payment but got Bolt11 payment.");
+		Ok(PaymentResult::Bolt11 { payment_id: _ }) => {
+			panic!("Expected on-chain payment but got Bolt11");
 		},
 		Ok(PaymentResult::Onchain { txid }) => {
-			println!("on-chain transaction successful with Txid: {}", txid);
+			println!("\nOn-chain transaction successful with Txid: {}", txid);
 			txid
 		},
 		Err(e) => {
-			println!("Error to send payment with URI: {:?}", e);
-			panic!("Expected on-chain payment but got error");
+			panic!("Expected on-chain payment but got error: {:?}", e);
 		},
 	};
 
@@ -656,6 +666,5 @@ fn unified_qr_send_receive() {
 	node_b.sync_wallets().unwrap();
 
 	assert_eq!(node_b.list_balances().total_onchain_balance_sats, 800_000);
-	println!("Node B on-chain balance: {:?}", node_b.list_balances().total_onchain_balance_sats);
-	println!("Node B lighting balance: {:?}", node_b.list_balances().total_lightning_balance_sats)
+	assert_eq!(node_b.list_balances().total_lightning_balance_sats, 200_000);
 }