fix node operators snapshot

Author: bulbozaur

tests/snapshot/test_node_operators_registry.py

@@ -7,10 +7,7 @@
 from brownie.convert.datatypes import ReturnValue
 from tests.snapshot.utils import get_slot
 
-from utils.config import (
-    contracts,
-    DEPOSIT_SECURITY_MODULE
-)
+from utils.config import contracts, DEPOSIT_SECURITY_MODULE
 from utils.mainnet_fork import chain_snapshot
 from utils.test.snapshot_helpers import dict_zip
 from utils.test.governance_helpers import execute_vote_and_process_dg_proposals
@@ -30,7 +27,13 @@ def grant_roles(voting_eoa, agent_eoa):
         contracts.voting,
         contracts.node_operators_registry,
         convert.to_uint(Web3.keccak(text="MANAGE_NODE_OPERATOR_ROLE")),
-        {"from": contracts.agent},
+        {"from": agent_eoa},
+    )
+    contracts.acl.grantPermission(
+        agent_eoa,
+        contracts.node_operators_registry,
+        convert.to_uint(Web3.keccak(text="SET_NODE_OPERATOR_LIMIT_ROLE")),
+        {"from": agent_eoa},
     )
 
 
@@ -101,7 +104,7 @@ def create_actions(dsm_eoa, manager_eoa):
                 new_node_operator["id"],
                 new_node_operator["staking_limit"],
                 1,
-                {"from": manager_eoa},
+                {"from": new_node_operator["reward_address"]},
             ),
             "deactivate_node_operator": lambda: contracts.node_operators_registry.deactivateNodeOperator(
                 new_node_operator["id"], {"from": manager_eoa}
@@ -121,7 +124,9 @@ def create_actions(dsm_eoa, manager_eoa):
     make_snapshot(contracts.node_operators_registry)
 
     with chain_snapshot():
-        snapshot_before_update = run_scenario(actions=create_actions(new_deposit_security_module_eoa, voting_eoa), snapshooter=make_snapshot)
+        snapshot_before_update = run_scenario(
+            actions=create_actions(new_deposit_security_module_eoa, agent_eoa), snapshooter=make_snapshot
+        )
 
     with chain_snapshot():
         execute_vote_and_process_dg_proposals(helpers, vote_ids_from_env, dg_proposal_ids_from_env)
@@ -130,22 +135,24 @@ def create_actions(dsm_eoa, manager_eoa):
             contracts.agent,
             contracts.node_operators_registry,
             convert.to_uint(Web3.keccak(text="MANAGE_NODE_OPERATOR_ROLE")),
-            {"from": contracts.agent}
+            {"from": contracts.agent},
         )
         contracts.acl.grantPermission(
             contracts.agent,
             contracts.node_operators_registry,
             convert.to_uint(Web3.keccak(text="SET_NODE_OPERATOR_LIMIT_ROLE")),
-            {"from": contracts.agent}
+            {"from": contracts.agent},
         )
         contracts.acl.grantPermission(
             contracts.agent,
             contracts.node_operators_registry,
             convert.to_uint(Web3.keccak(text="MANAGE_SIGNING_KEYS")),
-            {"from": contracts.agent}
+            {"from": contracts.agent},
         )
 
-        snapshot_after_update = run_scenario(actions=create_actions(new_deposit_security_module_eoa, agent_eoa), snapshooter=make_snapshot)
+        snapshot_after_update = run_scenario(
+            actions=create_actions(new_deposit_security_module_eoa, agent_eoa), snapshooter=make_snapshot
+        )
 
     assert snapshot_before_update.keys() == snapshot_after_update.keys()
 
@@ -262,8 +269,14 @@ def assert_node_operators(before: Dict[str, ReturnValue], after: Dict[str, Retur
         node_operator_before = node_operators_pair[0]
         node_operator_after = node_operators_pair[1]
         assert node_operator_before["active"] == node_operator_after["active"]
-        assert node_operator_before["name"] == node_operator_after["name"]
-        assert node_operator_before["rewardAddress"] == node_operator_after["rewardAddress"]
+        if id == 25:
+            assert node_operator_before["name"] == "Nethermind"
+            assert node_operator_after["name"] == "Twinstake"
+            assert node_operator_before["rewardAddress"] == "0x237DeE529A47750bEcdFa8A59a1D766e3e7B5F91"
+            assert node_operator_after["rewardAddress"] == "0x36201ed66DbC284132046ee8d99272F8eEeb24c8"
+        else:
+            assert node_operator_before["name"] == node_operator_after["name"]
+            assert node_operator_before["rewardAddress"] == node_operator_after["rewardAddress"]
         assert node_operator_before["totalDepositedValidators"] == node_operator_after["totalDepositedValidators"]
         assert node_operator_before["totalExitedValidators"] == node_operator_after["totalExitedValidators"]
         assert node_operator_before["totalAddedValidators"] == node_operator_after["totalAddedValidators"]