Skip to content

Commit 617ff5a

Browse files
abayerlbernick
authored andcommitted
TEP-0046: Mark as implemented
tektoncd/pipeline#3843 was merged back in June. Signed-off-by: Andrew Bayer <[email protected]>
1 parent 128e3e8 commit 617ff5a

File tree

2 files changed

+9
-4
lines changed

2 files changed

+9
-4
lines changed

teps/0046-finallytask-execution-post-timeout.md

Lines changed: 8 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,8 @@
11
---
2-
status: implementable
2+
status: implemented
33
title: Finally tasks execution post pipelinerun timeout
44
creation-date: '2021-01-26'
5-
last-updated: '2021-04-14'
5+
last-updated: '2021-12-14'
66
authors:
77
- '@souleb'
88
---
@@ -24,6 +24,7 @@ authors:
2424
- [Finally block level timeout flag](#finally-block-level-timeout-flag)
2525
- [Pipelinerun timeout is inclusive of the finally tasks timeout](#pipelinerun-timeout-is-inclusive-of-the-finally-tasks-timeout)
2626
- [Finally Timeout flag at Pipelinerun Spec](#finally-timeout-flag-at-pipelinerun-spec)
27+
- [References](#references)
2728
<!-- /toc -->
2829

2930
## Summary
@@ -308,4 +309,8 @@ This solution was deemed confusing. The user could expect the `timeout` to be fo
308309

309310
### Finally Timeout flag at Pipelinerun Spec
310311

311-
We could add a new flag at the pipelineRun level `finallyTimeout` similar to the timeout flag. If specified, pipelineRun timeout (default is one hour) applies to dag tasks only. The dag tasks will stop executing once it meets the pipelineRun timeout. The finally tasks starts executing at this point and will be executed until meets the timeout specified in finallyTimeout.
312+
We could add a new flag at the pipelineRun level `finallyTimeout` similar to the timeout flag. If specified, pipelineRun timeout (default is one hour) applies to dag tasks only. The dag tasks will stop executing once it meets the pipelineRun timeout. The finally tasks starts executing at this point and will be executed until meets the timeout specified in finallyTimeout.
313+
314+
## References
315+
316+
* [tektoncd/pipeline PR #3843 - Add a Timeouts optional field to pipelinerun](https://github.com/tektoncd/pipeline/pull/3843)

teps/README.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -198,7 +198,7 @@ This is the complete list of Tekton teps:
198198
|[TEP-0042](0042-taskrun-breakpoint-on-failure.md) | taskrun-breakpoint-on-failure | implemented | 2021-12-10 |
199199
|[TEP-0044](0044-decouple-task-composition-from-scheduling.md) | Decouple Task Composition from Scheduling | proposed | 2021-12-14 |
200200
|[TEP-0045](0045-whenexpressions-in-finally-tasks.md) | WhenExpressions in Finally Tasks | implemented | 2021-06-03 |
201-
|[TEP-0046](0046-finallytask-execution-post-timeout.md) | Finally tasks execution post pipelinerun timeout | implementable | 2021-04-14 |
201+
|[TEP-0046](0046-finallytask-execution-post-timeout.md) | Finally tasks execution post pipelinerun timeout | implemented | 2021-12-14 |
202202
|[TEP-0047](0047-pipeline-task-display-name.md) | Pipeline Task Display Name | proposed | 2021-02-10 |
203203
|[TEP-0048](0048-task-results-without-results.md) | Task Results without Results | proposed | 2021-06-11 |
204204
|[TEP-0049](0049-aggregate-status-of-dag-tasks.md) | Aggregate Status of DAG Tasks | implemented | 2021-06-03 |

0 commit comments

Comments
 (0)