refactor: singleton cv combining ECDSA and BN254 #479
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ypatil12
requested changes
May 16, 2025
|
|
||
| /* BN254 CERTIFICATE VERIFIER INTERFACE */ | ||
|
|
||
| /** |
Imo, less confusing if its one interface for a single contract but not too opposed |
ypatil12
approved these changes
May 19, 2025
ypatil12
pushed a commit
that referenced
this pull request
Jul 10, 2025
**Motivation:** Redesigning to have a singleton CertificateVerifier that is deployed per destination chain where the AVSs utilizing this contract trust the `globalOperatorTableRoot` is valid and the EigenDA operatorSet which configures this in a timely basis. **Modifications:** - Combined the ECDSACertificateVerifier and the BN254CertificateVerifier interfaces into CertificateVerifier. - OperatorSet configuration parameters are now configured on the L1 via a `CrossChainRegistry` contract and transported by the following functions. - `ICertificateVerifier.updateECDSAOperatorTable` or `ICertificateVerifier.updateBN254OperatorTable` **Result:** Standarizing interface with a canonical CertVerifier contract and less deployment duplication from AVSs.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
Redesigning to have a singleton CertificateVerifier that is deployed per destination chain where the AVSs utilizing this contract trust the
globalOperatorTableRootis valid and the EigenDA operatorSet which configures this in a timely basis.Modifications:
CrossChainRegistrycontract and transported by the following functions.ICertificateVerifier.updateECDSAOperatorTableorICertificateVerifier.updateBN254OperatorTableResult:
Standarizing interface with a canonical CertVerifier contract and less deployment duplication from AVSs.