[12.x] Test configurationIsCached #57774
Closed
+43
−2
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The application
configurationIsCachedmethod is currently controlled by 2 factors:Therefore, I added some small tests here to prevent unexpected breaking changes later if any.
a config cache file does not exist
configurationIsCachedreturnsfalseand "config_loaded_from_cache" is implicitly set asfalsetrue,configurationIsCachedreturnstrue.false,configurationIsCachedreturnsfalse.a config cache file exist
configurationIsCachedreturnstrueand "config_loaded_from_cache" is implicitly set astruefalse,configurationIsCachedreturnsfalse.Plus
inside the
RegisterProvidersclass, instead of accessingconfig_loaded_from_cachedirectly, usingconfigurationIsCachedis more consistent because:config_loaded_from_cacheshould be called with a "setter" in order to change the config cache state.configurationIsCachedshould be called with a "getter" in order to check the config cache state.