Skip to content

Commit 595297e

Browse files
authored
core: Add support for calls in get_function_nonlocals (#29255)
Thank you for contributing to LangChain! - [ ] **PR title**: "package: description" - Where "package" is whichever of langchain, community, core, etc. is being modified. Use "docs: ..." for purely docs changes, "infra: ..." for CI changes. - Example: "community: add foobar LLM" - [ ] **PR message**: ***Delete this entire checklist*** and replace with - **Description:** a description of the change - **Issue:** the issue # it fixes, if applicable - **Dependencies:** any dependencies required for this change - **Twitter handle:** if your PR gets announced, and you'd like a mention, we'll gladly shout you out! - [ ] **Add tests and docs**: If you're adding a new integration, please include 1. a test for the integration, preferably unit tests that do not rely on network access, 2. an example notebook showing its use. It lives in `docs/docs/integrations` directory. - [ ] **Lint and test**: Run `make format`, `make lint` and `make test` from the root of the package(s) you've modified. See contribution guidelines for more: https://python.langchain.com/docs/contributing/ Additional guidelines: - Make sure optional dependencies are imported within a function. - Please do not add dependencies to pyproject.toml files (even optional ones) unless they are required for unit tests. - Most PRs should not touch more than one package. - Changes should be backwards compatible. - If you are adding something to community, do not re-import it in langchain. If no one reviews your PR within a few days, please @-mention one of baskaryan, efriis, eyurtsev, ccurme, vbarda, hwchase17.
1 parent 75663f2 commit 595297e

File tree

1 file changed

+14
-0
lines changed
  • libs/core/langchain_core/runnables

1 file changed

+14
-0
lines changed

libs/core/langchain_core/runnables/utils.py

Lines changed: 14 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -271,6 +271,20 @@ def visit_Attribute(self, node: ast.Attribute) -> Any:
271271
if isinstance(parent, ast.Name):
272272
self.loads.add(parent.id + "." + attr_expr)
273273
self.loads.discard(parent.id)
274+
elif isinstance(parent, ast.Call):
275+
if isinstance(parent.func, ast.Name):
276+
self.loads.add(parent.func.id)
277+
else:
278+
parent = parent.func
279+
attr_expr = ""
280+
while isinstance(parent, ast.Attribute):
281+
if attr_expr:
282+
attr_expr = parent.attr + "." + attr_expr
283+
else:
284+
attr_expr = parent.attr
285+
parent = parent.value
286+
if isinstance(parent, ast.Name):
287+
self.loads.add(parent.id + "." + attr_expr)
274288

275289

276290
class FunctionNonLocals(ast.NodeVisitor):

0 commit comments

Comments
 (0)