feat(l2): add support for web3signer (#2714)

**Motivation**

<!-- Why does this pull request exist? What are its goals? -->
Many operators will want to use a remote signer instead of having the
private keys on the same server as the sequencer.

**Description**

<!-- A clear and concise general description of the changes this PR
introduces -->
Replace all uses of a private key with a new `Signer` enum. This signer
can be either `Local` or `Remote` and can be lately extended. This aims
to standardise the way all kind of messages are signed across the L2 and
facilitate the setup via flags or environment

<!-- Link to issues: Resolves #111, Resolves #222 -->

---------

Co-authored-by: Javier Rodríguez Chatruc <[email protected]>
Co-authored-by: fedacking <[email protected]>
Co-authored-by: Avila Gastón <[email protected]>

Author: 4 people

.github/workflows/pr-main_l2.yaml

@@ -58,8 +58,16 @@ jobs:
         include:
           - name: "Validium"
             validium: true
+            web3signer: false
+            compose_targets: [docker-compose-l2.yaml]
           - name: "Vanilla"
             validium: false
+            web3signer: false
+            compose_targets: [docker-compose-l2.yaml]
+          - name: "Vanilla with Web3signer"
+            validium: false
+            web3signer: true
+            compose_targets: [docker-compose-l2.yaml, docker-compose-l2-web3signer.yaml]
     steps:
       - name: Checkout sources
         uses: actions/checkout@v4
@@ -83,6 +91,12 @@ jobs:
         run: |
           cargo test l2 --no-run --release
 
+      - name: Start Web3Signer
+        if: matrix.web3signer
+        run: |
+          cd crates/l2
+          docker compose -f ${{ join(matrix.compose_targets, ' -f ') }} up --detach web3signer
+          
       - name: Build L1 docker image
         uses: docker/build-push-action@v6
         with:
@@ -109,7 +123,7 @@ jobs:
           CI_ETHREX_WORKDIR=/usr/local/bin \
           ETHREX_L2_VALIDIUM=${{ matrix.validium }} \
           ETHREX_WATCHER_BLOCK_DELAY=0 \
-          docker compose -f docker-compose-l2.yaml up --detach ethrex_l2
+          docker compose -f ${{ join(matrix.compose_targets, ' -f ') }} up --detach ethrex_l2
 
       - name: Run test
         run: |

Cargo.lock

@@ -96,6 +96,8 @@ axum = "0.8.1"
 clap = { version = "4.3", features = ["derive", "env"] }
 clap_complete = "4.5.17"
 eyre = "0.6.12"
+rustc-hex = "2.1.0"
+url = "2.5.4"
 kzg-rs = "0.2.6"
 libsql = "0.9.10"
 futures = "0.3.31"

Cargo.toml

@@ -41,13 +41,15 @@ lazy_static.workspace = true
 secp256k1 = { workspace = true }
 keccak-hash.workspace = true
 reqwest.workspace = true
+thiserror.workspace = true
 itertools = "0.14.0"
 tui-logger.workspace = true
 
 cfg-if = "1.0.0"
 
 ethrex-dev = { path = "../../crates/blockchain/dev", optional = true }
 ethrex-metrics = { path = "../../crates/blockchain/metrics" }
+url.workspace = true
 
 [[bin]]
 name = "ethrex"

cmd/ethrex/Cargo.toml

@@ -14,12 +14,13 @@ use ethrex_blockchain::{
     payload::{BuildPayloadArgs, PayloadBuildResult, create_payload},
 };
 use ethrex_common::{
-    Address, H160, U256,
+    Address, H160,
     types::{
-        Block, EIP1559Transaction, Genesis, GenesisAccount, LegacyTransaction, Signable,
-        Transaction, TxKind, payload::PayloadBundle,
+        Block, EIP1559Transaction, Genesis, GenesisAccount, Transaction, TxKind,
+        payload::PayloadBundle,
     },
 };
+use ethrex_l2_rpc::signer::{LocalSigner, Signable, Signer};
 use ethrex_storage::{EngineType, Store};
 use ethrex_vm::EvmEngine;
 use secp256k1::SecretKey;
@@ -112,19 +113,8 @@ fn read_private_keys() -> Vec<SecretKey> {
 }
 
 fn recover_address_for_sk(sk: &SecretKey) -> Address {
-    let mut tx = Transaction::LegacyTransaction(LegacyTransaction {
-        nonce: 0,
-        gas_price: 1,
-        to: TxKind::Call(H160::random()),
-        value: U256::zero(),
-        data: Bytes::new(),
-        v: U256::one(),
-        r: U256::one(),
-        s: U256::one(),
-        gas: 21000,
-    });
-    tx.sign_inplace(sk).expect("Unreachable error: Digest to sign should be correct size since it's calculated with the keccak algorithm");
-    tx.sender().expect("Failed to recover sender's address")
+    let signer = Signer::Local(LocalSigner::new(*sk));
+    signer.address()
 }
 
 async fn setup_genesis(accounts: &Vec<Address>) -> (Store, Genesis) {
@@ -171,6 +161,7 @@ async fn create_payload_block(genesis_block: &Block, store: &Store) -> (Block, u
 async fn fill_mempool(b: &Blockchain, accounts: Vec<SecretKey>) {
     let mut txs = vec![];
     for sk in accounts {
+        let signer = Signer::Local(LocalSigner::new(sk));
         for n in 0..1000 {
             let mut tx = Transaction::EIP1559Transaction(EIP1559Transaction {
                 nonce: n,
@@ -182,7 +173,7 @@ async fn fill_mempool(b: &Blockchain, accounts: Vec<SecretKey>) {
                 to: TxKind::Call(H160::random()),
                 ..Default::default()
             });
-            tx.sign_inplace(&sk).expect("Unreachable error: Digest to sign should be correct size since it's calculated with the keccak algorithm");
+            let _ = tx.sign_inplace(&signer).await;
             txs.push(tx);
         }
     }

cmd/ethrex/bench/build_block_benchmark.rs

@@ -41,7 +41,7 @@ use std::{
 };
 use tokio::sync::Mutex;
 use tokio_util::task::TaskTracker;
-use tracing::info;
+use tracing::{error, info};
 
 #[allow(clippy::large_enum_variant)]
 #[derive(Subcommand)]
@@ -199,7 +199,10 @@ impl Command {
                     info!("P2P is disabled");
                 }
 
-                let l2_sequencer_cfg = SequencerConfig::from(opts.sequencer_opts);
+                let l2_sequencer_cfg =
+                    SequencerConfig::try_from(opts.sequencer_opts).inspect_err(|err| {
+                        error!("{err}");
+                    })?;
 
                 let l2_sequencer = ethrex_l2::start_l2(
                     store,