fix: dont kill container (#2780)

## Description
This PR makes it so that on container failure, services are stopped
instead of removed. This makes it possible for Kurtosis to display error
logs from the failed container during kurtosis runs.

Author: tedim52

container-engine-lib/lib/backend_impls/docker/docker_kurtosis_backend/user_services_functions/stop_user_services.go

@@ -2,6 +2,8 @@ package user_service_functions
 
 import (
 	"context"
+	"time"
+
 	"github.com/kurtosis-tech/kurtosis/container-engine-lib/lib/backend_impls/docker/docker_kurtosis_backend/shared_helpers"
 	"github.com/kurtosis-tech/kurtosis/container-engine-lib/lib/backend_impls/docker/docker_manager"
 	"github.com/kurtosis-tech/kurtosis/container-engine-lib/lib/backend_impls/docker/docker_operation_parallelizer"
@@ -11,6 +13,10 @@ import (
 	"github.com/kurtosis-tech/stacktrace"
 )
 
+const (
+	stopContainerTimeout = 10 * time.Second
+)
+
 func StopUserServices(
 	ctx context.Context,
 	enclaveUuid enclave.EnclaveUUID,
@@ -43,8 +49,8 @@ func StopUserServices(
 		dockerManager *docker_manager.DockerManager,
 		dockerObjectId string,
 	) error {
-		if err := dockerManager.KillContainer(ctx, dockerObjectId); err != nil {
-			return stacktrace.Propagate(err, "An error occurred killing user service container with ID '%v'", dockerObjectId)
+		if err := dockerManager.StopContainer(ctx, dockerObjectId, stopContainerTimeout); err != nil {
+			return stacktrace.Propagate(err, "An error occurred stopping user service container with ID '%v'", dockerObjectId)
 		}
 		return nil
 	}

container-engine-lib/lib/backend_impls/docker/docker_manager/docker_manager.go

@@ -160,6 +160,8 @@ const (
 	//The Docker or Podman network name where all the containers in the engine and logs service context will be added
 	NameOfNetworkToStartEngineAndLogServiceContainersInDocker = "bridge"
 	NameOfNetworkToStartEngineAndLogServiceContainersInPodman = "podman"
+
+	defaultContainerStopTimeout = 1 * time.Second
 )
 
 type RestartPolicy string
@@ -731,7 +733,8 @@ func (manager *DockerManager) CreateAndStartContainer(
 	functionFinishedSuccessfully := false
 	defer func() {
 		if !functionFinishedSuccessfully {
-			if err := manager.KillContainer(ctx, containerId); err != nil {
+			// Instead of killing the container, stop it so that logs are still available
+			if err := manager.StopContainer(ctx, containerId, defaultContainerStopTimeout); err != nil {
 				logrus.Error("The container creation function didn't finish successfully, meaning we needed to kill the container we created. However, the killing threw an error:")
 				fmt.Fprintln(logrus.StandardLogger().Out, err)
 				logrus.Errorf("ACTION NEEDED: You'll need to manually kill this container with ID '%v'", containerId)
@@ -741,6 +744,7 @@ func (manager *DockerManager) CreateAndStartContainer(
 
 	//Check if the container dies because sometimes users starts containers with a wrong configuration and these quickly dies
 	didContainerStartSuccessfully, err := manager.didContainerStartSuccessfully(ctx, containerId, dockerImage)
+	logrus.Infof("didContainerStartSuccessfully: %v", didContainerStartSuccessfully)
 	if err != nil {
 		return "", nil, stacktrace.Propagate(err, "An error occurred checking if container '%v' is running", containerId)
 	}

core/server/api_container/server/service_network/default_service_network.go

@@ -990,13 +990,13 @@ func (network *DefaultServiceNetwork) startRegisteredService(
 			},
 			Statuses: nil,
 		}
-		_, failedToDestroyUuids, err := network.kurtosisBackend.DestroyUserServices(context.Background(), network.enclaveUuid, userServiceFilters)
+		_, failedToDestroyUuids, err := network.kurtosisBackend.StopUserServices(context.Background(), network.enclaveUuid, userServiceFilters)
 		if err != nil {
-			logrus.Errorf("Attempted to destroy the services with UUIDs '%v' but had no success. You must manually destroy the services! The following error had occurred:\n'%v'", serviceToDestroyUuid, err)
+			logrus.Errorf("Attempted to stop the services with UUIDs '%v' but had no success. You must manually stop the services! The following error had occurred:\n'%v'", serviceToDestroyUuid, err)
 			return
 		}
 		if failedToDestroyErr, found := failedToDestroyUuids[serviceToDestroyUuid]; found {
-			logrus.Errorf("Attempted to destroy the services with UUIDs '%v' but had no success. You must manually destroy the services! The following error had occurred:\n'%v'", serviceToDestroyUuid, failedToDestroyErr)
+			logrus.Errorf("Attempted to stop the services with UUIDs '%v' but had no success. You must manually stop the services! The following error had occurred:\n'%v'", serviceToDestroyUuid, failedToDestroyErr)
 		}
 	}()