Skip to content

Commit 59bbbee

Browse files
authored
Merge pull request #31 from JKLiang9714/huawei-1230
[Huawei]fix log level when operation fallback
2 parents a859eb9 + 925b7b2 commit 59bbbee

File tree

1 file changed

+14
-14
lines changed

1 file changed

+14
-14
lines changed

ompi/mca/coll/ucx/coll_ucx_op.c

Lines changed: 14 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -170,7 +170,7 @@ int mca_coll_ucx_allreduce(const void *sbuf, void *rbuf, int count,
170170
ompi_datatype_type_extent(dtype, &extent);
171171
ucs_status_t ret = mca_coll_ucx_check_total_data_size((size_t)extent, count);
172172
if (OPAL_UNLIKELY(ret != UCS_OK)) {
173-
COLL_UCX_WARN("ucx component only support data size <= 2^32 bytes, fallback to ompi function.");
173+
COLL_UCX_VERBOSE(1, "ucx component only support data size <= 2^32 bytes, fallback to ompi function.");
174174
goto fallback;
175175
}
176176

@@ -195,13 +195,13 @@ int mca_coll_ucx_allreduce(const void *sbuf, void *rbuf, int count,
195195
ret = ucg_coll_allreduce_init(sbuf_rel, rbuf, count, (size_t)extent, dtype, ucx_module->ucg_group, 0,
196196
op, 0, 0, &coll);
197197
if (OPAL_UNLIKELY(ret != UCS_OK)) {
198-
COLL_UCX_WARN("ucx allreduce init failed: %s, fallback to ompi function.", ucs_status_string(ret));
198+
COLL_UCX_VERBOSE(1, "ucx allreduce init failed: %s, fallback to ompi function.", ucs_status_string(ret));
199199
goto fallback;
200200
}
201201

202202
ret = ucg_collective_start_nbr(coll, req);
203203
if (OPAL_UNLIKELY(UCS_STATUS_IS_ERR(ret))) {
204-
COLL_UCX_WARN("ucx allreduce start failed: %s, fallback to ompi function.", ucs_status_string(ret));
204+
COLL_UCX_VERBOSE(1, "ucx allreduce start failed: %s, fallback to ompi function.", ucs_status_string(ret));
205205
goto fallback;
206206
}
207207

@@ -550,13 +550,13 @@ int mca_coll_ucx_alltoallv(const void *sbuf, const int *scounts, const int *sdis
550550
is_recv_contig = mca_coll_ucg_check_contig_datatype(rdtype);
551551

552552
if (!is_send_contig || !is_recv_contig) {
553-
COLL_UCX_WARN("current hmpi alltoallv cannot support non-contig datatype, fallback to ompi function.");
553+
COLL_UCX_VERBOSE(1, "current hmpi alltoallv cannot support non-contig datatype, fallback to ompi function.");
554554
goto fallback;
555555
}
556556

557557
/* large datatype */
558558
if (sdtype_size > LARGE_DATATYPE_THRESHOLD || rdtype_size > LARGE_DATATYPE_THRESHOLD) {
559-
COLL_UCX_WARN("current hmpi alltoallv cannot support large datatype, fallback to ompi function.");
559+
COLL_UCX_VERBOSE(1, "current hmpi alltoallv cannot support large datatype, fallback to ompi function.");
560560
goto fallback;
561561
}
562562

@@ -570,7 +570,7 @@ int mca_coll_ucx_alltoallv(const void *sbuf, const int *scounts, const int *sdis
570570
}
571571
ret = mca_coll_ucx_check_total_data_size((size_t)sdtype_size, total_send_count);
572572
if (OPAL_UNLIKELY(ret != UCS_OK)) {
573-
COLL_UCX_WARN("ucx component only support data size <= 2^32 bytes, fallback to ompi function.");
573+
COLL_UCX_VERBOSE(1, "ucx component only support data size <= 2^32 bytes, fallback to ompi function.");
574574
goto fallback;
575575
}
576576

@@ -580,7 +580,7 @@ int mca_coll_ucx_alltoallv(const void *sbuf, const int *scounts, const int *sdis
580580
}
581581
ret = mca_coll_ucx_check_total_data_size((size_t)rdtype_size, total_recv_count);
582582
if (OPAL_UNLIKELY(ret != UCS_OK)) {
583-
COLL_UCX_WARN("ucx component only support data size <= 2^32 bytes, fallback to ompi function.");
583+
COLL_UCX_VERBOSE(1, "ucx component only support data size <= 2^32 bytes, fallback to ompi function.");
584584
goto fallback;
585585
}
586586

@@ -589,7 +589,7 @@ int mca_coll_ucx_alltoallv(const void *sbuf, const int *scounts, const int *sdis
589589
rbuf, rcounts, (size_t)rdtype_size, rdtype, rdispls,
590590
ucx_module->ucg_group, 0, 0, 0, 0, &coll);
591591
if (OPAL_UNLIKELY(ret != UCS_OK)) {
592-
COLL_UCX_WARN("ucx alltoallv init failed: %s", ucs_status_string(ret));
592+
COLL_UCX_VERBOSE(1, "ucx alltoallv init failed: %s", ucs_status_string(ret));
593593
goto fallback;
594594
}
595595

@@ -601,7 +601,7 @@ int mca_coll_ucx_alltoallv(const void *sbuf, const int *scounts, const int *sdis
601601
ucs_status_ptr_t req = request + mca_coll_ucx_component.request_size;
602602
ret = ucg_collective_start_nbr(coll, req);
603603
if (OPAL_UNLIKELY(UCS_STATUS_IS_ERR(ret))) {
604-
COLL_UCX_WARN("ucx alltoallv start failed: %s", ucs_status_string(ret));
604+
COLL_UCX_VERBOSE(1, "ucx alltoallv start failed: %s", ucs_status_string(ret));
605605
goto fallback;
606606
}
607607

@@ -635,13 +635,13 @@ int mca_coll_ucx_barrier(struct ompi_communicator_t *comm, mca_coll_base_module_
635635
ucg_coll_h coll = NULL;
636636
ucs_status_t ret = ucg_coll_barrier_init(0, ucx_module->ucg_group, 0, 0, 0, 0, &coll);
637637
if (OPAL_UNLIKELY(ret != UCS_OK)) {
638-
COLL_UCX_WARN("ucx barrier init failed: %s, fallback to ompi function.", ucs_status_string(ret));
638+
COLL_UCX_VERBOSE(1, "ucx barrier init failed: %s, fallback to ompi function.", ucs_status_string(ret));
639639
goto fallback;
640640
}
641641

642642
ret = ucg_collective_start_nbr(coll, req);
643643
if (OPAL_UNLIKELY(UCS_STATUS_IS_ERR(ret))) {
644-
COLL_UCX_WARN("ucx barrier start failed: %s, fallback to ompi function.", ucs_status_string(ret));
644+
COLL_UCX_VERBOSE(1, "ucx barrier start failed: %s, fallback to ompi function.", ucs_status_string(ret));
645645
goto fallback;
646646
}
647647

@@ -677,19 +677,19 @@ int mca_coll_ucx_bcast(void *buff, int count, struct ompi_datatype_t *dtype, int
677677
ompi_datatype_type_extent(dtype, &dtype_size);
678678
ucs_status_t ret = mca_coll_ucx_check_total_data_size((size_t)dtype_size, count);
679679
if (OPAL_UNLIKELY(ret != UCS_OK)) {
680-
COLL_UCX_WARN("ucx component only support data size <= 2^32 bytes, fallback to ompi function.");
680+
COLL_UCX_VERBOSE(1, "ucx component only support data size <= 2^32 bytes, fallback to ompi function.");
681681
goto fallback;
682682
}
683683
ret = ucg_coll_bcast_init(buff, buff, count, (size_t)dtype_size, dtype, ucx_module->ucg_group, 0,
684684
0, root, 0, &coll);
685685
if (OPAL_UNLIKELY(UCS_STATUS_IS_ERR(ret))) {
686-
COLL_UCX_WARN("ucx bcast init failed: %s, fallback to ompi function.", ucs_status_string(ret));
686+
COLL_UCX_VERBOSE(1, "ucx bcast init failed: %s, fallback to ompi function.", ucs_status_string(ret));
687687
goto fallback;
688688
}
689689

690690
ret = ucg_collective_start_nbr(coll, req);
691691
if (OPAL_UNLIKELY(UCS_STATUS_IS_ERR(ret))) {
692-
COLL_UCX_WARN("ucx bcast start failed: %s, fallback to ompi function.", ucs_status_string(ret));
692+
COLL_UCX_VERBOSE(1, "ucx bcast start failed: %s, fallback to ompi function.", ucs_status_string(ret));
693693
goto fallback;
694694
}
695695

0 commit comments

Comments
 (0)