Fix names/doc in transformation config code.

Author: monopole

internal/k8sdeps/transformer/hash/namehash.go

@@ -24,8 +24,6 @@ import (
 	"sigs.k8s.io/kustomize/pkg/transformers"
 )
 
-// nameHashTransformer contains the prefix and the path config for each field that
-// the name prefix will be applied.
 type nameHashTransformer struct{}
 
 var _ transformers.Transformer = &nameHashTransformer{}

pkg/commands/misc/config.go

@@ -102,7 +102,7 @@ func (o *saveOptions) Complete(fsys fs.FileSystem) error {
 
 // RunSave saves the default transformer configurations local directory
 func (o *saveOptions) RunSave(fsys fs.FileSystem) error {
-	m := defaultconfig.GetDefaultPathConfigStrings()
+	m := defaultconfig.GetDefaultFieldSpecsAsMap()
 	for tname, tcfg := range m {
 		filename := filepath.Join(o.saveDirectory, tname+".yaml")
 		err := fsys.WriteFile(filename, []byte(tcfg))

pkg/target/kusttarget.go

@@ -132,8 +132,8 @@ func (kt *KustTarget) loadCustomizedResMap() (resmap.ResMap, error) {
 	if err != nil {
 		errs.Append(errors.Wrap(err, "loadResMapFromBasesAndResources"))
 	}
-	crdPathConfigs, err := config.NewFactory(kt.ldr).LoadCRDs(kt.kustomization.Crds)
-	kt.tcfg = kt.tcfg.Merge(crdPathConfigs)
+	crdTc, err := config.NewFactory(kt.ldr).LoadCRDs(kt.kustomization.Crds)
+	kt.tcfg = kt.tcfg.Merge(crdTc)
 	if err != nil {
 		errs.Append(errors.Wrap(err, "LoadCRDs"))
 	}

pkg/transformers/config/defaultconfig/commonannotations.go

@@ -16,7 +16,7 @@ limitations under the License.
 
 package defaultconfig
 
-const commonAnnotationPathConfigs = `
+const commonAnnotationFieldSpecs = `
 commonAnnotations:
 - path: metadata/annotations
   create: true

pkg/transformers/config/defaultconfig/commonlabels.go

@@ -16,7 +16,7 @@ limitations under the License.
 
 package defaultconfig
 
-const commonLabelPathConfigs = `
+const commonLabelFieldSpecs = `
 commonLabels:
 - path: metadata/labels
   create: true

pkg/transformers/config/defaultconfig/defaultconfig.go

@@ -22,27 +22,28 @@ import (
 	"bytes"
 )
 
-// GetDefaultPathConfigs returns the default pathConfigs data
-func GetDefaultPathConfigs() []byte {
+// GetDefaultFieldSpecs returns default fieldSpecs.
+func GetDefaultFieldSpecs() []byte {
 	configData := [][]byte{
-		[]byte(namePrefixPathConfigs),
-		[]byte(commonLabelPathConfigs),
-		[]byte(commonAnnotationPathConfigs),
-		[]byte(namespacePathConfigs),
-		[]byte(varReferencePathConfigs),
-		[]byte(nameReferencePathConfigs),
+		[]byte(namePrefixFieldSpecs),
+		[]byte(commonLabelFieldSpecs),
+		[]byte(commonAnnotationFieldSpecs),
+		[]byte(namespaceFieldSpecs),
+		[]byte(varReferenceFieldSpecs),
+		[]byte(nameReferenceFieldSpecs),
 	}
 	return bytes.Join(configData, []byte("\n"))
 }
 
-// GetDefaultPathConfigStrings returns the default pathConfigs in string format
-func GetDefaultPathConfigStrings() map[string]string {
+// GetDefaultFieldSpecsAsMap returns default fieldSpecs
+// as a string->string map.
+func GetDefaultFieldSpecsAsMap() map[string]string {
 	result := make(map[string]string)
-	result["nameprefix"] = namePrefixPathConfigs
-	result["commonlabels"] = commonLabelPathConfigs
-	result["commonannotations"] = commonAnnotationPathConfigs
-	result["namespace"] = namespacePathConfigs
-	result["varreference"] = varReferencePathConfigs
-	result["namereference"] = namespacePathConfigs
+	result["nameprefix"] = namePrefixFieldSpecs
+	result["commonlabels"] = commonLabelFieldSpecs
+	result["commonannotations"] = commonAnnotationFieldSpecs
+	result["namespace"] = namespaceFieldSpecs
+	result["varreference"] = varReferenceFieldSpecs
+	result["namereference"] = nameReferenceFieldSpecs
 	return result
 }

pkg/transformers/config/defaultconfig/nameprefix.go

@@ -17,7 +17,7 @@ limitations under the License.
 package defaultconfig
 
 const (
-	namePrefixPathConfigs = `
+	namePrefixFieldSpecs = `
 namePrefix:
 - path: metadata/name
 `

pkg/transformers/config/defaultconfig/namereference.go

@@ -17,26 +17,26 @@ limitations under the License.
 package defaultconfig
 
 const (
-	nameReferencePathConfigs = `
+	nameReferenceFieldSpecs = `
 nameReference:
 - kind: Deployment
-  pathConfigs:
+  fieldSpecs:
   - path: spec/scaleTargetRef/name
     kind: HorizontalPodAutoscaler
 
 - kind: ReplicationController
-  pathConfigs:
+  fieldSpecs:
   - path: spec/scaleTargetRef/name
     kind: HorizontalPodAutoscaler
 
 - kind: ReplicaSet
-  pathConfigs:
+  fieldSpecs:
   - path: spec/scaleTargetRef/name
     kind: HorizontalPodAutoscaler
 
 - kind: ConfigMap
   version: v1
-  pathConfigs:
+  fieldSpecs:
   - path: spec/volumes/configMap/name
     version: v1
     kind: Pod
@@ -119,7 +119,7 @@ nameReference:
 
 - kind: Secret
   version: v1
-  pathConfigs:
+  fieldSpecs:
   - path: spec/volumes/secret/secretName
     version: v1
     kind: Pod
@@ -229,7 +229,7 @@ nameReference:
 
 - kind: Service
   version: v1
-  pathConfigs:
+  fieldSpecs:
   - path: spec/serviceName
     kind: StatefulSet
     group: apps
@@ -240,14 +240,14 @@ nameReference:
 
 - kind: Role
   group: rbac.authorization.k8s.io
-  pathConfigs:
+  fieldSpecs:
   - path: roleRef/name
     kind: RoleBinding
     group: rbac.authorization.k8s.io
 
 - kind: ClusterRole
   group: rbac.authorization.k8s.io
-  pathConfigs:
+  fieldSpecs:
   - path: roleRef/name
     kind: RoleBinding
     group: rbac.authorization.k8s.io
@@ -257,7 +257,7 @@ nameReference:
 
 - kind: ServiceAccount
   version: v1
-  pathConfigs:
+  fieldSpecs:
   - path: subjects/name
     kind: RoleBinding
     group: rbac.authorization.k8s.io
@@ -281,7 +281,7 @@ nameReference:
 
 - kind: PersistentVolumeClaim
   version: v1
-  pathConfigs:
+  fieldSpecs:
   - path: spec/volumes/persistentVolumeClaim/claimName
     kind: Pod
   - path: spec/template/spec/volumes/persistentVolumeClaim/claimName
@@ -299,7 +299,7 @@ nameReference:
 
 - kind: PersistentVolume
   version: v1
-  pathConfigs:
+  fieldSpecs:
   - path: spec/volumeName
     kind: PersistentVolumeClaim
 `

pkg/transformers/config/defaultconfig/namespace.go

@@ -17,7 +17,7 @@ limitations under the License.
 package defaultconfig
 
 const (
-	namespacePathConfigs = `
+	namespaceFieldSpecs = `
 namespace:
 - path: metadata/namespace
   create: true

pkg/transformers/config/defaultconfig/varreference.go

@@ -17,7 +17,7 @@ limitations under the License.
 package defaultconfig
 
 const (
-	varReferencePathConfigs = `
+	varReferenceFieldSpecs = `
 varReference:
 - path: spec/template/spec/initContainers/command
   kind: StatefulSet