Skip to content

Commit ba617e5

Browse files
authored
Merge pull request #5921 from ThisIsQasim/imagevolume
feat: Add suport for Image Volumes
2 parents 7558804 + 32e8251 commit ba617e5

File tree

2 files changed

+82
-0
lines changed

2 files changed

+82
-0
lines changed

api/filters/imagetag/imagetag_test.go

Lines changed: 78 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -879,6 +879,84 @@ spec:
879879
},
880880
},
881881
},
882+
"update image volume in pod template": {
883+
input: `
884+
group: apps
885+
apiVersion: v1
886+
kind: Deployment
887+
metadata:
888+
name: imagevolume
889+
spec:
890+
template:
891+
spec:
892+
volumes:
893+
- name: volume
894+
image:
895+
reference: nginx
896+
`,
897+
expectedOutput: `
898+
group: apps
899+
apiVersion: v1
900+
kind: Deployment
901+
metadata:
902+
name: imagevolume
903+
spec:
904+
template:
905+
spec:
906+
volumes:
907+
- name: volume
908+
image:
909+
reference: apache@12345
910+
`,
911+
filter: Filter{
912+
ImageTag: types.Image{
913+
Name: "nginx",
914+
NewName: "apache",
915+
Digest: "12345",
916+
},
917+
},
918+
fsSlice: []types.FieldSpec{
919+
{
920+
Path: "spec/template/spec/volumes[]/image/reference",
921+
},
922+
},
923+
},
924+
"update image volume in pod spec": {
925+
input: `
926+
apiVersion: v1
927+
kind: Pod
928+
metadata:
929+
name: imagevolume
930+
spec:
931+
volumes:
932+
- name: volume
933+
image:
934+
reference: nginx
935+
`,
936+
expectedOutput: `
937+
apiVersion: v1
938+
kind: Pod
939+
metadata:
940+
name: imagevolume
941+
spec:
942+
volumes:
943+
- name: volume
944+
image:
945+
reference: apache@12345
946+
`,
947+
filter: Filter{
948+
ImageTag: types.Image{
949+
Name: "nginx",
950+
NewName: "apache",
951+
Digest: "12345",
952+
},
953+
},
954+
fsSlice: []types.FieldSpec{
955+
{
956+
Path: "spec/volumes[]/image/reference",
957+
},
958+
},
959+
},
882960
}
883961

884962
for tn, tc := range testCases {

api/internal/konfig/builtinpluginconsts/images.go

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -10,9 +10,13 @@ images:
1010
create: true
1111
- path: spec/initContainers[]/image
1212
create: true
13+
- path: spec/volumes[]/image/reference
14+
create: true
1315
- path: spec/template/spec/containers[]/image
1416
create: true
1517
- path: spec/template/spec/initContainers[]/image
1618
create: true
19+
- path: spec/template/spec/volumes[]/image/reference
20+
create: true
1721
`
1822
)

0 commit comments

Comments
 (0)