error out if patchesJson6902 target can't be found, fixes #335

schweikert · schweikert · commit 279826f6d6c4 · 2018-10-03T21:53:45.000+02:00
diff --git a/pkg/patch/transformer/util.go b/pkg/patch/transformer/util.go
@@ -18,7 +18,6 @@ package transformer
 
 import (
 	"fmt"
-	"log"
 
 	"sigs.k8s.io/kustomize/pkg/resmap"
 	"sigs.k8s.io/kustomize/pkg/resource"
@@ -37,8 +36,7 @@ func findTargetObj(m resmap.ResMap, targetId resource.ResId) (*resource.Resource
 	}
 
 	if len(matchedIds) == 0 {
-		log.Printf("Couldn't find any object to apply the json patch %v, skipping it.", targetId)
-		return nil, nil
+		return nil, fmt.Errorf("couldn't find any object to apply the json patch %v", targetId)
 	}
 	if len(matchedIds) > 1 {
 		return nil, fmt.Errorf("found multiple objects that the patch can apply %v", matchedIds)

Original file line number	Diff line number	Diff line change
`@@ -18,7 +18,6 @@ package transformer`
`18`	`18`
`19`	`19`	`import (`
`20`	`20`	`"fmt"`
`21`		`- "log"`
`22`	`21`
`23`	`22`	`"sigs.k8s.io/kustomize/pkg/resmap"`
`24`	`23`	`"sigs.k8s.io/kustomize/pkg/resource"`
`@@ -37,8 +36,7 @@ func findTargetObj(m resmap.ResMap, targetId resource.ResId) (*resource.Resource`
`37`	`36`	`}`
`38`	`37`
`39`	`38`	`if len(matchedIds) == 0 {`
`40`		`- log.Printf("Couldn't find any object to apply the json patch %v, skipping it.", targetId)`
`41`		`- return nil, nil`
	`39`	`+ return nil, fmt.Errorf("couldn't find any object to apply the json patch %v", targetId)`
`42`	`40`	`}`
`43`	`41`	`if len(matchedIds) > 1 {`
`44`	`42`	`return nil, fmt.Errorf("found multiple objects that the patch can apply %v", matchedIds)`