added notifications for plugins feature parsers in kong

Author: Devaansh-Kumar

.gitignore

@@ -26,3 +26,6 @@ go.work
 
 # GolangCI-Lint cache
 /cache
+
+# VSCode files for debugging
+.vscode/

pkg/i2gw/notifications/notifications.go

@@ -98,6 +98,6 @@ func convertObjectsToStr(ob []client.Object) string {
 	return sb.String()
 }
 
-func NotificationBuilder(mType MessageType, message string, callingObject ...client.Object) Notification {
+func NewNotification(mType MessageType, message string, callingObject ...client.Object) Notification {
 	return Notification{Type: mType, Message: message, CallingObjects: callingObject}
-}
+}

pkg/i2gw/providers/istio/notification.go

@@ -22,6 +22,6 @@ import (
 )
 
 func notify(mType notifications.MessageType, message string, callingObject ...client.Object) {
-	newNotification := notifications.NotificationBuilder(mType, message, callingObject...)
+	newNotification := notifications.NewNotification(mType, message, callingObject...)
 	notifications.NotificationAggr.DispatchNotification(newNotification, string(ProviderName))
 }

pkg/i2gw/providers/kong/crds/tcpingress.go

@@ -81,11 +81,11 @@ func (a *tcpIngressAggregator) addIngress(tcpIngress kongv1beta1.TCPIngress, not
 	var ingressClass string
 	if ingressClassAnnotation, ok := tcpIngress.Annotations[networkingv1beta1.AnnotationIngressClass]; ok {
 		ingressClass = tcpIngress.Annotations[networkingv1beta1.AnnotationIngressClass]
-		n := notifications.NotificationBuilder(notifications.InfoNotification, fmt.Sprintf("ingress class \"%v\" taken from %v annotation", ingressClassAnnotation, networkingv1beta1.AnnotationIngressClass), &tcpIngress)
+		n := notifications.NewNotification(notifications.InfoNotification, fmt.Sprintf("ingress class \"%v\" taken from %v annotation", ingressClassAnnotation, networkingv1beta1.AnnotationIngressClass), &tcpIngress)
 		*notificationsAggregator = append(*notificationsAggregator, n)
 	} else {
 		ingressClass = tcpIngress.Name
-		n := notifications.NotificationBuilder(notifications.InfoNotification, "ingress class taken from name of TCPIngress", &tcpIngress)
+		n := notifications.NewNotification(notifications.InfoNotification, "ingress class taken from name of TCPIngress", &tcpIngress)
 		*notificationsAggregator = append(*notificationsAggregator, n)
 	}
 	for _, rule := range tcpIngress.Spec.Rules {

pkg/i2gw/providers/kong/header_matching.go

@@ -83,7 +83,7 @@ func patchHTTPRouteHeaderMatching(httpRoute *gatewayv1.HTTPRoute, headerNames []
 		}
 		httpRoute.Spec.Rules[i].Matches = newMatches
 		if len(newMatches) > 0 {
-			notify(notifications.InfoNotification, fmt.Sprintf("parsed \"%v\" annotations of ingress and patched %v fields", kongAnnotation(headersKey), field.NewPath("httproute", "spec", "rules").Key("").Child("matches")), httpRoute)
+			notify(notifications.InfoNotification, fmt.Sprintf("parsed \"%v\" annotation of ingress and patched %v fields", kongAnnotation(headersKey), field.NewPath("httproute", "spec", "rules").Key("").Child("matches")), httpRoute)
 		}
 	}
 }

pkg/i2gw/providers/kong/method_matching.go

@@ -69,7 +69,7 @@ func patchHTTPRouteMethodMatching(httpRoute *gatewayv1.HTTPRoute, methods []gate
 		}
 		if len(matches) > 0 {
 			httpRoute.Spec.Rules[i].Matches = matches
-			notify(notifications.InfoNotification, fmt.Sprintf("parsed \"%v\" annotations of ingress and patched %v fields", kongAnnotation(methodsKey), field.NewPath("httproute", "spec", "rules").Key("").Child("matches").Key("").Child("method")), httpRoute)
+			notify(notifications.InfoNotification, fmt.Sprintf("parsed \"%v\" annotation of ingress and patched %v fields", kongAnnotation(methodsKey), field.NewPath("httproute", "spec", "rules").Key("").Child("matches").Key("").Child("method")), httpRoute)
 		}
 	}
 }

pkg/i2gw/providers/kong/notification.go

@@ -22,12 +22,12 @@ import (
 )
 
 func notify(mType notifications.MessageType, message string, callingObject ...client.Object) {
-	newNotification := notifications.NotificationBuilder(mType, message, callingObject...)
+	newNotification := notifications.NewNotification(mType, message, callingObject...)
 	notifications.NotificationAggr.DispatchNotification(newNotification, string(Name))
 }
 
 func dispatchNotification(n []notifications.Notification) {
 	for _, v := range n {
 		notify(v.Type, v.Message, v.CallingObjects...)
 	}
-}
+}

pkg/i2gw/providers/kong/plugins.go

@@ -18,9 +18,11 @@ package kong
 
 import (
 	"errors"
+	"fmt"
 	"strings"
 
 	"github.com/kubernetes-sigs/ingress2gateway/pkg/i2gw"
+	"github.com/kubernetes-sigs/ingress2gateway/pkg/i2gw/notifications"
 	"github.com/kubernetes-sigs/ingress2gateway/pkg/i2gw/providers/common"
 	networkingv1 "k8s.io/api/networking/v1"
 	"k8s.io/apimachinery/pkg/types"
@@ -81,4 +83,7 @@ func patchHTTPRoutePlugins(httpRoute *gatewayv1.HTTPRoute, extensionRefs []gatew
 		}
 		httpRoute.Spec.Rules[i].Filters = append(httpRoute.Spec.Rules[i].Filters, extensionRefs...)
 	}
+	if len(extensionRefs) != 0 {
+		notify(notifications.InfoNotification, fmt.Sprintf("parsed \"%v\" annotation of ingress and patched %v fields", kongAnnotation(pluginsKey), field.NewPath("httproute", "spec", "rules").Key("").Child("filters")), httpRoute)
+	}
 }