chore(build): Clean up excessive warnings from "make generate"

Signed-off-by: Flynn <[email protected]>

Author: kflynn

apis/v1alpha2/object_reference_types.go

@@ -18,43 +18,8 @@ package v1alpha2
 
 import v1 "sigs.k8s.io/gateway-api/apis/v1"
 
-// LocalObjectReference identifies an API object within the namespace of the
-// referrer.
-// The API object must be valid in the cluster; the Group and Kind must
-// be registered in the cluster for this reference to be valid.
-//
-// References to objects with invalid Group and Kind are not valid, and must
-// be rejected by the implementation, with appropriate Conditions set
-// on the containing object.
-// +k8s:deepcopy-gen=false
 type LocalObjectReference = v1.LocalObjectReference
 
-// SecretObjectReference identifies an API object including its namespace,
-// defaulting to Secret.
-//
-// The API object must be valid in the cluster; the Group and Kind must
-// be registered in the cluster for this reference to be valid.
-//
-// References to objects with invalid Group and Kind are not valid, and must
-// be rejected by the implementation, with appropriate Conditions set
-// on the containing object.
-// +k8s:deepcopy-gen=false
 type SecretObjectReference = v1.SecretObjectReference
 
-// BackendObjectReference defines how an ObjectReference that is
-// specific to BackendRef. It includes a few additional fields and features
-// than a regular ObjectReference.
-//
-// Note that when a namespace different than the local namespace is specified, a
-// ReferenceGrant object is required in the referent namespace to allow that
-// namespace's owner to accept the reference. See the ReferenceGrant
-// documentation for details.
-//
-// The API object must be valid in the cluster; the Group and Kind must
-// be registered in the cluster for this reference to be valid.
-//
-// References to objects with invalid Group and Kind are not valid, and must
-// be rejected by the implementation, with appropriate Conditions set
-// on the containing object.
-// +k8s:deepcopy-gen=false
 type BackendObjectReference = v1.BackendObjectReference

apis/v1alpha2/referencegrant_types.go

@@ -59,16 +59,8 @@ type ReferenceGrantList struct {
 	Items           []ReferenceGrant `json:"items"`
 }
 
-// ReferenceGrantSpec identifies a cross namespace relationship that is trusted
-// for Gateway API.
-// +k8s:deepcopy-gen=false
 type ReferenceGrantSpec = v1beta1.ReferenceGrantSpec
 
-// ReferenceGrantFrom describes trusted namespaces and kinds.
-// +k8s:deepcopy-gen=false
 type ReferenceGrantFrom = v1beta1.ReferenceGrantFrom
 
-// ReferenceGrantTo describes what Kinds are allowed as targets of the
-// references.
-// +k8s:deepcopy-gen=false
 type ReferenceGrantTo = v1beta1.ReferenceGrantTo

apis/v1alpha2/shared_types.go

@@ -18,44 +18,11 @@ package v1alpha2
 
 import v1 "sigs.k8s.io/gateway-api/apis/v1"
 
-// ParentReference identifies an API object (usually a Gateway) that can be considered
-// a parent of this resource (usually a route). The only kind of parent resource
-// with "Core" support is Gateway. This API may be extended in the future to
-// support additional kinds of parent resources, such as HTTPRoute.
-//
-// Note that there are specific rules for ParentRefs which cross namespace
-// boundaries. Cross-namespace references are only valid if they are explicitly
-// allowed by something in the namespace they are referring to. For example:
-// Gateway has the AllowedRoutes field, and ReferenceGrant provides a
-// generic way to enable any other kind of cross-namespace reference.
-//
-// The API object must be valid in the cluster; the Group and Kind must
-// be registered in the cluster for this reference to be valid.
-// +k8s:deepcopy-gen=false
 type ParentReference = v1.ParentReference
-
-// CommonRouteSpec defines the common attributes that all Routes MUST include
-// within their spec.
-// +k8s:deepcopy-gen=false
 type CommonRouteSpec = v1.CommonRouteSpec
-
-// PortNumber defines a network port.
 type PortNumber = v1.PortNumber
-
-// BackendRef defines how a Route should forward a request to a Kubernetes
-// resource.
-//
-// Note that when a namespace different than the local namespace is specified, a
-// ReferenceGrant object is required in the referent namespace to allow that
-// namespace's owner to accept the reference. See the ReferenceGrant
-// documentation for details.
-// +k8s:deepcopy-gen=false
 type BackendRef = v1.BackendRef
-
-// RouteConditionType is a type of condition for a route.
 type RouteConditionType = v1.RouteConditionType
-
-// RouteConditionReason is a reason for a route condition.
 type RouteConditionReason = v1.RouteConditionReason
 
 const (
@@ -140,214 +107,19 @@ const (
 	RouteReasonBackendNotFound RouteConditionReason = "BackendNotFound"
 )
 
-// RouteParentStatus describes the status of a route with respect to an
-// associated Parent.
-// +k8s:deepcopy-gen=false
 type RouteParentStatus = v1.RouteParentStatus
-
-// RouteStatus defines the common attributes that all Routes MUST include within
-// their status.
-// +k8s:deepcopy-gen=false
 type RouteStatus = v1.RouteStatus
-
-// Hostname is the fully qualified domain name of a network host. This matches
-// the RFC 1123 definition of a hostname with 2 notable exceptions:
-//
-//  1. IPs are not allowed.
-//  2. A hostname may be prefixed with a wildcard label (`*.`). The wildcard
-//     label must appear by itself as the first label.
-//
-// Hostname can be "precise" which is a domain name without the terminating
-// dot of a network host (e.g. "foo.example.com") or "wildcard", which is a
-// domain name prefixed with a single wildcard label (e.g. `*.example.com`).
-//
-// Note that as per RFC1035 and RFC1123, a *label* must consist of lower case
-// alphanumeric characters or '-', and must start and end with an alphanumeric
-// character. No other punctuation is allowed.
-//
-// +kubebuilder:validation:MinLength=1
-// +kubebuilder:validation:MaxLength=253
-// +kubebuilder:validation:Pattern=`^(\*\.)?[a-z0-9]([-a-z0-9]*[a-z0-9])?(\.[a-z0-9]([-a-z0-9]*[a-z0-9])?)*$`
 type Hostname = v1.Hostname
-
-// PreciseHostname is the fully qualified domain name of a network host. This
-// matches the RFC 1123 definition of a hostname with 1 notable exception that
-// numeric IP addresses are not allowed.
-//
-// Note that as per RFC1035 and RFC1123, a *label* must consist of lower case
-// alphanumeric characters or '-', and must start and end with an alphanumeric
-// character. No other punctuation is allowed.
-//
-// +kubebuilder:validation:MinLength=1
-// +kubebuilder:validation:MaxLength=253
-// +kubebuilder:validation:Pattern=`^[a-z0-9]([-a-z0-9]*[a-z0-9])?(\.[a-z0-9]([-a-z0-9]*[a-z0-9])?)*$`
 type PreciseHostname = v1.PreciseHostname
-
-// Group refers to a Kubernetes Group. It must either be an empty string or a
-// RFC 1123 subdomain.
-//
-// This validation is based off of the corresponding Kubernetes validation:
-// https://github.com/kubernetes/apimachinery/blob/02cfb53916346d085a6c6c7c66f882e3c6b0eca6/pkg/util/validation/validation.go#L208
-//
-// Valid values include:
-//
-// * "" - empty string implies core Kubernetes API group
-// * "networking.k8s.io"
-// * "foo.example.com"
-//
-// Invalid values include:
-//
-// * "example.com/bar" - "/" is an invalid character
-//
-// +kubebuilder:validation:MaxLength=253
-// +kubebuilder:validation:Pattern=`^$|^[a-z0-9]([-a-z0-9]*[a-z0-9])?(\.[a-z0-9]([-a-z0-9]*[a-z0-9])?)*$`
 type Group = v1.Group
-
-// Kind refers to a Kubernetes Kind.
-//
-// Valid values include:
-//
-// * "Service"
-// * "HTTPRoute"
-//
-// Invalid values include:
-//
-// * "invalid/kind" - "/" is an invalid character
-//
-// +kubebuilder:validation:MinLength=1
-// +kubebuilder:validation:MaxLength=63
-// +kubebuilder:validation:Pattern=`^[a-zA-Z]([-a-zA-Z0-9]*[a-zA-Z0-9])?$`
 type Kind = v1.Kind
-
-// ObjectName refers to the name of a Kubernetes object.
-// Object names can have a variety of forms, including RFC1123 subdomains,
-// RFC 1123 labels, or RFC 1035 labels.
-//
-// +kubebuilder:validation:MinLength=1
-// +kubebuilder:validation:MaxLength=253
 type ObjectName = v1.ObjectName
-
-// Namespace refers to a Kubernetes namespace. It must be a RFC 1123 label.
-//
-// This validation is based off of the corresponding Kubernetes validation:
-// https://github.com/kubernetes/apimachinery/blob/02cfb53916346d085a6c6c7c66f882e3c6b0eca6/pkg/util/validation/validation.go#L187
-//
-// This is used for Namespace name validation here:
-// https://github.com/kubernetes/apimachinery/blob/02cfb53916346d085a6c6c7c66f882e3c6b0eca6/pkg/api/validation/generic.go#L63
-//
-// Valid values include:
-//
-// * "example"
-//
-// Invalid values include:
-//
-// * "example.com" - "." is an invalid character
-//
-// +kubebuilder:validation:Pattern=`^[a-z0-9]([-a-z0-9]*[a-z0-9])?$`
-// +kubebuilder:validation:MinLength=1
-// +kubebuilder:validation:MaxLength=63
 type Namespace = v1.Namespace
-
-// SectionName is the name of a section in a Kubernetes resource.
-//
-// In the following resources, SectionName is interpreted as the following:
-//
-// * Gateway: Listener name
-// * HTTPRoute: HTTPRouteRule name
-// * Service: Port name
-//
-// Section names can have a variety of forms, including RFC 1123 subdomains,
-// RFC 1123 labels, or RFC 1035 labels.
-//
-// This validation is based off of the corresponding Kubernetes validation:
-// https://github.com/kubernetes/apimachinery/blob/02cfb53916346d085a6c6c7c66f882e3c6b0eca6/pkg/util/validation/validation.go#L208
-//
-// Valid values include:
-//
-// * "example"
-// * "foo-example"
-// * "example.com"
-// * "foo.example.com"
-//
-// Invalid values include:
-//
-// * "example.com/bar" - "/" is an invalid character
-//
-// +kubebuilder:validation:Pattern=`^[a-z0-9]([-a-z0-9]*[a-z0-9])?(\.[a-z0-9]([-a-z0-9]*[a-z0-9])?)*$`
-// +kubebuilder:validation:MinLength=1
-// +kubebuilder:validation:MaxLength=253
 type SectionName = v1.SectionName
-
-// GatewayController is the name of a Gateway API controller. It must be a
-// domain prefixed path.
-//
-// Valid values include:
-//
-// * "example.com/bar"
-//
-// Invalid values include:
-//
-// * "example.com" - must include path
-// * "foo.example.com" - must include path
-//
-// +kubebuilder:validation:MinLength=1
-// +kubebuilder:validation:MaxLength=253
-// +kubebuilder:validation:Pattern=`^[a-z0-9]([-a-z0-9]*[a-z0-9])?(\.[a-z0-9]([-a-z0-9]*[a-z0-9])?)*\/[A-Za-z0-9\/\-._~%!$&'()*+,;=:]+$`
 type GatewayController = v1.GatewayController
-
-// AnnotationKey is the key of an annotation in Gateway API. This is used for
-// validation of maps such as TLS options. This matches the Kubernetes
-// "qualified name" validation that is used for annotations and other common
-// values.
-//
-// Valid values include:
-//
-// * example
-// * example.com
-// * example.com/path
-// * example.com/path.html
-//
-// Invalid values include:
-//
-// * example~ - "~" is an invalid character
-// * example.com. - cannot start or end with "."
-//
-// +kubebuilder:validation:MinLength=1
-// +kubebuilder:validation:MaxLength=253
-// +kubebuilder:validation:Pattern=`^(([A-Za-z0-9][-A-Za-z0-9_.]*)?[A-Za-z0-9]/?)*$`
 type AnnotationKey = v1.AnnotationKey
-
-// AnnotationValue is the value of an annotation in Gateway API. This is used
-// for validation of maps such as TLS options. This roughly matches Kubernetes
-// annotation validation, although the length validation in that case is based
-// on the entire size of the annotations struct.
-//
-// +kubebuilder:validation:MinLength=0
-// +kubebuilder:validation:MaxLength=4096
 type AnnotationValue = v1.AnnotationValue
-
-// AddressType defines how a network address is represented as a text string.
-// This may take two possible forms:
-//
-// * A predefined CamelCase string identifier (currently limited to `IPAddress` or `Hostname`)
-// * A domain-prefixed string identifier (like `acme.io/CustomAddressType`)
-//
-// Values `IPAddress` and `Hostname` have Extended support.
-//
-// The `NamedAddress` value has been deprecated in favor of implementation
-// specific domain-prefixed strings.
-//
-// All other values, including domain-prefixed values have Implementation-specific support,
-// which are used in implementation-specific behaviors. Support for additional
-// predefined CamelCase identifiers may be added in future releases.
-//
-// +kubebuilder:validation:MinLength=1
-// +kubebuilder:validation:MaxLength=253
-// +kubebuilder:validation:Pattern=`^Hostname|IPAddress|NamedAddress|[a-z0-9]([-a-z0-9]*[a-z0-9])?(\.[a-z0-9]([-a-z0-9]*[a-z0-9])?)*\/[A-Za-z0-9\/\-._~%!$&'()*+,;=:]+$`
 type AddressType = v1.AddressType
-
-// Duration is a string value representing a duration in time. The format is as specified
-// in GEP-2257, a strict subset of the syntax parsed by Golang time.ParseDuration.
 type Duration = v1.Duration
 
 const (
@@ -382,7 +154,4 @@ const (
 	NamedAddressType AddressType = "NamedAddress"
 )
 
-// SessionPersistence defines the desired state of
-// SessionPersistence.
-// +k8s:deepcopy-gen=false
 type SessionPersistence = v1.SessionPersistence