Skip to content
This repository was archived by the owner on Jul 30, 2025. It is now read-only.

Commit 3ce0210

Browse files
committed
feat(plugins/plugin-client-common): wizard mini progress should use our Spinner component
this works better in a grid ui than the patternfly circular loop spinner
1 parent df3ce90 commit 3ce0210

File tree

4 files changed

+10
-3
lines changed

4 files changed

+10
-3
lines changed

plugins/plugin-client-common/src/components/Content/MiniProgressStepper.tsx

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -18,8 +18,9 @@ import React from 'react'
1818
import { i18n, pexecInCurrentTab } from '@kui-shell/core'
1919

2020
import Tooltip from '../spi/Tooltip'
21+
import Spinner from '../Views/Terminal/Block/Spinner'
2122
import { emitLinkUpdate, subscribeToLinkUpdates, unsubscribeToLinkUpdates } from './LinkStatus'
22-
import { ProgressStepState, statusFromStatusVector, statusToClassName, statusToIcon } from './ProgressStepper'
23+
import { ProgressStepState, statusFromStatusVector, statusToClassName } from './ProgressStepper'
2324

2425
import '../../../web/scss/components/Wizard/MiniProgressStepper.scss'
2526

@@ -76,7 +77,7 @@ export class MiniProgressStep extends React.PureComponent<MiniProps, ProgressSte
7677
}
7778

7879
private icon() {
79-
return this.status === 'in-progress' ? statusToIcon(this.status) : <React.Fragment />
80+
return this.status === 'in-progress' ? <Spinner /> : <React.Fragment />
8081
}
8182

8283
private get tooltipText() {

plugins/plugin-client-common/src/components/Views/Terminal/Block/Spinner.tsx

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -22,6 +22,8 @@
2222
import React from 'react'
2323
import 'spinkit/spinkit.min.css'
2424

25+
import '../../../../../web/scss/components/Terminal/Spinner.scss'
26+
2527
interface Props {
2628
className?: string
2729
}

plugins/plugin-client-common/web/scss/components/Terminal/_index.scss

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -26,4 +26,3 @@
2626
@import 'Playground';
2727
@import 'Scrollback';
2828
@import 'SourceRef';
29-
@import 'Spinner';

plugins/plugin-client-common/web/scss/components/Wizard/MiniProgressStepper.scss

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -14,6 +14,7 @@
1414
* limitations under the License.
1515
*/
1616

17+
@import '../Terminal/mixins';
1718
@import '../ProgressStepper/mixins';
1819

1920
$small: 0.5rem;
@@ -22,6 +23,10 @@ $regular: 0.75rem;
2223
@include MiniProgressStepper {
2324
--pf-c-progress-stepper__step-icon--Width: #{$regular};
2425

26+
@include Spinner {
27+
--sk-color: var(--color-yellow);
28+
}
29+
2530
@include Connector {
2631
align-items: center;
2732
height: $regular;

0 commit comments

Comments
 (0)