Skip to content

Added OSGi support and updated plugins #291 #292

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 25, 2018
Merged

Added OSGi support and updated plugins #291 #292

merged 1 commit into from
Jun 25, 2018

Conversation

@ieugen
Copy link
Contributor

@ieugen ieugen commented Jun 19, 2018 •
edited
Loading

  • fixes OSGi support? #291
  • added maven-bundle-plugin
  • changed packaging to bundle to generate osgi manifests
  • moved plugins to pluginManagement to have common versions
  • removed duplicate jar goal in client-java-api

Plugin version upgrade:

  • javadoc-plugin -> 3.0.1
  • source-plugin -> 3.0.1
  • release-plugin -> 2.5.3
  • compiler-plugin -> 2.5.3
  • compiler-plugin -> 3.7.0
  • build-helper-maven-plugin -> 3.0.0
  • jar-plugin -> 3.1.0
  • surefire-plugin -> 2.22.0
  • deploy-plugin -> 2.8.2

Added OSGi support and updated plugins #291
10c02e2 
* added maven-bundle-plugin
* changed packaging to bundle to generate osgi manifests
* moved plugins to pluginManagement to have common versions
* removed duplicate jar goal in client-java-api

Plugin version upgrade:
* javadoc-plugin -> 3.0.1
* source-plugin -> 3.0.1
* release-plugin -> 2.5.3
* compiler-plugin -> 2.5.3
* compiler-plugin -> 3.7.0
* build-helper-maven-plugin -> 3.0.0
* jar-plugin -> 3.1.0
* surefire-plugin -> 2.22.0
* deploy-plugin -> 2.8.2
@k8s-ci-robot k8s-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Jun 19, 2018
@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Jun 19, 2018

Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA.

It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.

  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
  • If you signed the CLA as a corporation, please sign in with your organization's credentials at https://identity.linuxfoundation.org/projects/cncf to be authorized.
  • If you have done the above and are still having issues with the CLA being reported as unsigned, please email the CNCF helpdesk: [email protected]

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. label Jun 19, 2018
@ieugen
Copy link
Contributor Author

ieugen commented Jun 19, 2018

signed cla

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Jun 19, 2018
@ieugen
Copy link
Contributor Author

ieugen commented Jun 19, 2018

My goal with this is to be able to integrate OSGi with Kubernetes via a custom ConfigAdmin implementation. That way configadmin can store configurations inside a kubernetes cluster instead of the file system and it gains some new powers: deploy an osgi app in different environments with ease.

It would be great if this makes it into 2.0.0

@brendandburns
Copy link
Contributor

brendandburns commented Jun 25, 2018

LGTM.

@brendandburns brendandburns merged commit 259ef60 into kubernetes-client:master Jun 25, 2018
@ieugen ieugen deleted the plugins-update-and-osgi branch June 25, 2018 15:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

OSGi support?

3 participants

@ieugen @k8s-ci-robot @brendandburns