Fixing logs

Author: johnugeorge

pkg/controller.v1beta1/suggestion/suggestionclient/suggestionclient.go

@@ -113,11 +113,10 @@ func (g *General) SyncAssignments(
 	if err != nil {
 		return err
 	}
-	logger.Info("Getting suggestions", "endpoint", endpoint, "response", len(responseSuggestion.ParameterAssignments),
-		"requestNum", requestNum)
+	logger.Info("Getting suggestions", "endpoint", endpoint, "Number of request parameters", requestNum, "Number of response parameters", len(responseSuggestion.ParameterAssignments))
 	if len(responseSuggestion.ParameterAssignments) != requestNum {
 		err := fmt.Errorf("The response contains unexpected trials")
-		logger.Error(err, "The response contains unexpected trials", "requestNum", requestNum, "response", len(responseSuggestion.ParameterAssignments))
+		logger.Error(err, "The response contains unexpected trials")
 		return err
 	}
 

pkg/suggestion/v1beta1/chocolate/base_service.py

@@ -160,15 +160,17 @@ def getSuggestions(self, trials, request_number, total_request_number):
         # Assuming that created_trials are already populated
         # TODO: Handle Restart of algorithm pod
         logger.info("{} Trials created in DB".format(len(self.created_trials)))
+        if total_request_number != len(self.created_trials) + request_number:
+            logger.info("Mismatch in generated trials with k8s suggestions trials")
         new_actual_requested_no = total_request_number - len(self.created_trials)
         prev_generated_no = request_number - new_actual_requested_no
         logger.info("In this call, New {} Trials will be generated, {} Trials will be reused from previously generated".format(new_actual_requested_no, prev_generated_no))
-        if total_request_number != len(self.created_trials) + request_number:
-            logger.info("Mismatch in generated trials with k8s suggestions trials")
 
         list_of_assignments = []
         if prev_generated_no > 0:
             for params in self.created_trials[-prev_generated_no:]:
+                if DB_FIELD_TRIAL_NAME in params:
+                    logger.error("Trial already updated in selected assignment {}".format(params))
                 new_assignment = BaseChocolateService.convert(
                         self.search_space, params)
                 list_of_assignments.append(new_assignment)