Skip to content

Commit f661f59

Browse files
committed
Add unit tests for optuna suggestion service
Signed-off-by: tenzen-y <[email protected]>
1 parent 1e90f4e commit f661f59

File tree

2 files changed

+90
-271
lines changed

2 files changed

+90
-271
lines changed

pkg/suggestion/v1beta1/optuna/service.py

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,6 @@
1515
import threading
1616
import grpc
1717
import logging
18-
1918
import itertools
2019

2120
from pkg.apis.manager.v1beta1.python import api_pb2
@@ -193,11 +192,11 @@ def _validate_grid_setting(cls, experiment):
193192

194193
for s in algorithm_settings:
195194
try:
196-
if s.name == "seed":
195+
if s.name == "random_state":
197196
if not int(s.value) >= 0:
198197
return False, ""
199-
else:
200-
return False, "unknown setting {} for algorithm grid".format(s.name)
198+
else:
199+
return False, "unknown setting {} for algorithm grid".format(s.name)
201200

202201
except Exception as e:
203202
return False, "failed to validate {name}({value}): {exception}".format(name=s.name, value=s.value,

0 commit comments

Comments
 (0)