Skip to content

Commit f40e328

Browse files
committed
Update Charmed Katib CI job
Updates general dependencies and fixes label selectors
1 parent b807144 commit f40e328

File tree

2 files changed

+25
-15
lines changed

2 files changed

+25
-15
lines changed

.github/workflows/test-charmed-katib.yaml

Lines changed: 23 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,9 @@ jobs:
1515

1616
- name: Install dependencies
1717
run: |
18-
sudo apt-get install python3-setuptools
18+
set -eux
19+
sudo apt update
20+
sudo apt install python3-setuptools
1921
sudo pip3 install black flake8
2022
2123
- name: Check black
@@ -34,19 +36,18 @@ jobs:
3436

3537
- uses: balchua/[email protected]
3638
with:
37-
channel: "1.20/stable"
39+
channel: "1.21/stable"
3840
addons: '["dns", "storage", "rbac"]'
3941

4042
- name: Install dependencies
4143
run: |
4244
set -eux
4345
sudo apt update
4446
sudo apt install -y python3-pip
45-
sudo snap install charm --classic
4647
sudo snap install juju --classic
47-
sudo snap install juju-helpers --classic
48+
sudo snap install juju-bundle --classic
4849
sudo snap install juju-wait --classic
49-
sudo pip3 install charmcraft==1.0.0
50+
sudo pip3 install charmcraft==1.3.1
5051
5152
- name: Build Docker images
5253
run: |
@@ -62,20 +63,20 @@ jobs:
6263
done
6364
6465
- name: Deploy Katib
66+
env:
67+
CHARMCRAFT_DEVELOPER: "1"
6568
run: |
6669
set -eux
6770
cd operators/
6871
git clone git://git.launchpad.net/canonical-osm
6972
cp -r canonical-osm/charms/interfaces/juju-relation-mysql mysql
7073
sg microk8s -c 'juju bootstrap microk8s uk8s'
7174
juju add-model kubeflow
72-
juju bundle deploy -b bundle-edge.yaml --build
75+
juju bundle deploy --build --destructive-mode --serial
7376
juju wait -wvt 300
7477
7578
- name: Test Katib
76-
run: |
77-
set -eux
78-
kubectl apply -f examples/v1beta1/hp-tuning/random.yaml
79+
run: kubectl apply -f examples/v1beta1/hp-tuning/random.yaml
7980

8081
- name: Get pod statuses
8182
run: kubectl get all -A
@@ -86,25 +87,32 @@ jobs:
8687
if: failure()
8788

8889
- name: Get katib-controller workload logs
89-
run: kubectl logs --tail 100 -nkubeflow -ljuju-app=katib-controller
90+
run: kubectl logs --tail 100 -nkubeflow -lapp.kubernetes.io/name=katib-controller
9091
if: failure()
9192

9293
- name: Get katib-controller operator logs
93-
run: kubectl logs --tail 100 -nkubeflow -ljuju-operator=katib-controller
94+
run: kubectl logs --tail 100 -nkubeflow -loperator.juju.is/name=katib-controller
9495
if: failure()
9596

9697
- name: Get katib-ui workload logs
97-
run: kubectl logs --tail 100 -nkubeflow -ljuju-app=katib-ui
98+
run: kubectl logs --tail 100 -nkubeflow -lapp.kubernetes.io/name=katib-ui
9899
if: failure()
99100

100101
- name: Get katib-ui operator logs
101-
run: kubectl logs --tail 100 -nkubeflow -ljuju-operator=katib-ui
102+
run: kubectl logs --tail 100 -nkubeflow -loperator.juju.is/name=katib-ui
102103
if: failure()
103104

104105
- name: Get katib-db-manager workload logs
105-
run: kubectl logs --tail 100 -nkubeflow -ljuju-app=katib-db-manager
106+
run: kubectl logs --tail 100 -nkubeflow -lapp.kubernetes.io/name=katib-db-manager
106107
if: failure()
107108

108109
- name: Get katib-db-manager operator logs
109-
run: kubectl logs --tail 100 -nkubeflow -ljuju-operator=katib-db-manager
110+
run: kubectl logs --tail 100 -nkubeflow -loperator.juju.is/name=katib-db-manager
111+
if: failure()
112+
113+
- name: Upload charmcraft logs
114+
uses: actions/upload-artifact@v2
115+
with:
116+
name: charmcraft-logs
117+
path: /tmp/charmcraft-log-*
110118
if: failure()

operators/pyproject.toml

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,2 @@
1+
[tool.isort]
2+
profile = "black"

0 commit comments

Comments
 (0)