TODO comment for using controller-runtime client for logs

d-gol · d-gol · commit ae7ba7cfd2bd · 2022-12-05T17:07:23.000+01:00
diff --git a/pkg/new-ui/v1beta1/backend.go b/pkg/new-ui/v1beta1/backend.go
@@ -634,6 +634,7 @@ func getTrialLogs(k *KatibUIHandler, trialName string, namespace string) (string
 		selectionLabel = selectionLabel + "," + primaryKey + "=" + primaryValue
 	}
 
+	// TODO: Use controller-runtime client instead of kubernetes client to get logs, once this is available
 	cfg, err := config.GetConfig()
 	if err != nil {
 		return "", err

Original file line number	Diff line number	Diff line change
`@@ -634,6 +634,7 @@ func getTrialLogs(k *KatibUIHandler, trialName string, namespace string) (string`
`634`	`634`	`selectionLabel = selectionLabel + "," + primaryKey + "=" + primaryValue`
`635`	`635`	`}`
`636`	`636`
	`637`	`+ // TODO: Use controller-runtime client instead of kubernetes client to get logs, once this is available`
`637`	`638`	`cfg, err := config.GetConfig()`
`638`	`639`	`if err != nil {`
`639`	`640`	`return "", err`