Skip to content

Commit ae5feb1

Browse files
committed
Add total requests field to tests
1 parent 1482e01 commit ae5feb1

File tree

2 files changed

+3
-1
lines changed

2 files changed

+3
-1
lines changed

pkg/suggestion/v1beta1/chocolate/base_service.py

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -157,7 +157,8 @@ def getSuggestions(self, trials, request_number, total_request_number):
157157
logger.info("New record in sqlite DB is updated")
158158
logger.info("{}\n".format(
159159
self.created_trials[new_trial_loss_idx]))
160-
160+
# Assuming that created_trials are already populated
161+
# TODO: Handle Restart of algorithm pod
161162
logger.info("{} Trials created in DB".format(len(self.created_trials)))
162163
new_actual_requested_no = total_request_number - len(self.created_trials)
163164
prev_generated_no = request_number - new_actual_requested_no

test/suggestion/v1beta1/test_chocolate_service.py

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -169,6 +169,7 @@ def test_get_suggestion(self):
169169
experiment=experiment,
170170
trials=trials,
171171
request_number=2,
172+
total_request_number=2,
172173
)
173174

174175
get_suggestion = self.test_server.invoke_unary_unary(

0 commit comments

Comments
 (0)