[review] fix vaiolation comments

Author: tenzen-y

pkg/suggestion/v1beta1/nas/darts/service.py

@@ -171,26 +171,26 @@ def validate_algorithm_settings(algorithm_settings: list[api_pb2.AlgorithmSettin
             # Validate weight decay
             if s.name in ["w_weight_decay", "alpha_weight_decay"]:
                 if not float(s.value) >= 0.0:
-                    return False, "{} should be greate or equal than zero".format(s.name)
+                    return False, "{} should be greater than or equal to zero".format(s.name)
 
             # Validate w_momentum and w_grad_clip
             if s.name in ["w_momentum", "w_grad_clip"]:
                 if not float(s.value) >= 0.0:
-                    return False, "{} should be greate or equal than zero".format(s.name)
+                    return False, "{} should be greater than or equal to zero".format(s.name)
 
             if s.name == "batch_size":
                 if s.value is not "None":
                     if not int(s.value) >= 1:
-                        return False, "batch_size should be greate or equal than one"
+                        return False, "batch_size should be greater than or equal to one"
 
             if s.name == "num_workers":
                 if not int(s.value) >= 0:
-                    return False, "num_workers should be greate or equal than zero"
+                    return False, "num_workers should be greater than or equal to zero"
 
             # Validate "init_channels", "print_step", "num_nodes" and "stem_multiplier"
             if s.name in ["init_channels", "print_step", "num_nodes", "stem_multiplier"]:
                 if not int(s.value) >= 1:
-                    return False, "{} should be greate or equal than one".format(s.name)
+                    return False, "{} should be greater than or equal to one".format(s.name)
 
         except Exception as e:
             return False, "failed to validate {name}({value}): {exception}".format(name=s.name, value=s.value,

test/unit/v1beta1/suggestion/test_darts_service.py

@@ -19,7 +19,7 @@
 
 from pkg.apis.manager.v1beta1.python import api_pb2
 
-from pkg.suggestion.v1beta1.nas.darts.service import DartsService, validate_algorithm_spec
+from pkg.suggestion.v1beta1.nas.darts.service import DartsService, validate_algorithm_settings
 
 
 class TestDarts(unittest.TestCase):
@@ -132,37 +132,37 @@ def test_validate_algorithm_spec(self):
             api_pb2.AlgorithmSetting(name="num_nodes", value="4"),
             api_pb2.AlgorithmSetting(name="stem_multiplier", value="3"),
         ]
-        is_valid, _ = validate_algorithm_spec(valid)
+        is_valid, _ = validate_algorithm_settings(valid)
         self.assertEqual(is_valid, True)
 
         # Invalid num_epochs
         invalid = [api_pb2.AlgorithmSetting(name="num_epochs", value="0")]
-        is_valid, _ = validate_algorithm_spec(invalid)
+        is_valid, _ = validate_algorithm_settings(invalid)
         self.assertEqual(is_valid, False)
 
         # Invalid w_lr
         invalid = [api_pb2.AlgorithmSetting(name="w_lr", value="-0.1")]
-        is_valid, _ = validate_algorithm_spec(invalid)
+        is_valid, _ = validate_algorithm_settings(invalid)
         self.assertEqual(is_valid, False)
 
         # Invalid alpha_weight_decay
         invalid = [api_pb2.AlgorithmSetting(name="alpha_weight_decay", value="-0.02")]
-        is_valid, _ = validate_algorithm_spec(invalid)
+        is_valid, _ = validate_algorithm_settings(invalid)
         self.assertEqual(is_valid, False)
 
         # Invalid w_momentum
         invalid = [api_pb2.AlgorithmSetting(name="w_momentum", value="-0.8")]
-        is_valid, _ = validate_algorithm_spec(invalid)
+        is_valid, _ = validate_algorithm_settings(invalid)
         self.assertEqual(is_valid, False)
 
         # Invalid batch_size
         invalid = [api_pb2.AlgorithmSetting(name="batch_size", value="0")]
-        is_valid, _ = validate_algorithm_spec(invalid)
+        is_valid, _ = validate_algorithm_settings(invalid)
         self.assertEqual(is_valid, False)
 
         # Invalid print_step
         invalid = [api_pb2.AlgorithmSetting(name="print_step", value="0")]
-        is_valid, _ = validate_algorithm_spec(invalid)
+        is_valid, _ = validate_algorithm_settings(invalid)
         self.assertEqual(is_valid, False)