Skip to content

Commit 58c7c3f

Browse files
committed
Drop Kubernetes v1.26, and support Kubernetes v1.29
Signed-off-by: Yuki Iwai <[email protected]>
1 parent 1365e47 commit 58c7c3f

File tree

22 files changed

+156
-137
lines changed

22 files changed

+156
-137
lines changed

.github/workflows/e2e-test-darts-cifar10.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -33,6 +33,6 @@ jobs:
3333
strategy:
3434
fail-fast: false
3535
matrix:
36-
kubernetes-version: ["v1.26.14", "v1.27.11", "v1.28.7"]
36+
kubernetes-version: ["v1.27.11", "v1.28.7", "v1.29.2"]
3737
# Comma Delimited
3838
experiments: ["darts-cpu"]

.github/workflows/e2e-test-enas-cifar10.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -33,6 +33,6 @@ jobs:
3333
strategy:
3434
fail-fast: false
3535
matrix:
36-
kubernetes-version: ["v1.26.14", "v1.27.11", "v1.28.7"]
36+
kubernetes-version: ["v1.27.11", "v1.28.7", "v1.29.2"]
3737
# Comma Delimited
3838
experiments: ["enas-cpu"]

.github/workflows/e2e-test-pytorch-mnist.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -34,7 +34,7 @@ jobs:
3434
strategy:
3535
fail-fast: false
3636
matrix:
37-
kubernetes-version: ["v1.26.14", "v1.27.11", "v1.28.7"]
37+
kubernetes-version: ["v1.27.11", "v1.28.7", "v1.29.2"]
3838
# Comma Delimited
3939
experiments:
4040
# suggestion-hyperopt

.github/workflows/e2e-test-simple-pbt.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -33,6 +33,6 @@ jobs:
3333
fail-fast: false
3434
matrix:
3535
# Detail: https://hub.docker.com/r/kindest/node
36-
kubernetes-version: ["v1.26.14", "v1.27.11", "v1.28.7"]
36+
kubernetes-version: ["v1.27.11", "v1.28.7", "v1.29.2"]
3737
# Comma Delimited
3838
experiments: ["simple-pbt"]

.github/workflows/e2e-test-tf-mnist-with-summaries.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -33,6 +33,6 @@ jobs:
3333
strategy:
3434
fail-fast: false
3535
matrix:
36-
kubernetes-version: ["v1.26.14", "v1.27.11", "v1.28.7"]
36+
kubernetes-version: ["v1.27.11", "v1.28.7", "v1.29.2"]
3737
# Comma Delimited
3838
experiments: ["tfjob-mnist-with-summaries"]

.github/workflows/e2e-test-ui-random-search-postgres.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -32,4 +32,4 @@ jobs:
3232
strategy:
3333
fail-fast: false
3434
matrix:
35-
kubernetes-version: ["v1.26.14", "v1.27.11", "v1.28.7"]
35+
kubernetes-version: ["v1.27.11", "v1.28.7", "v1.29.2"]

.github/workflows/test-go.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -65,7 +65,7 @@ jobs:
6565
fail-fast: false
6666
matrix:
6767
# Detail: `setup-envtest list`
68-
kubernetes-version: ["1.26.1", "1.27.1", "1.28.3"]
68+
kubernetes-version: ["1.27.1", "1.28.3", "1.29.3"]
6969

7070
# notifies that all test jobs are finished.
7171
finish:

Makefile

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@ HAS_MOCKGEN := $(shell command -v mockgen;)
77
COMMIT := v1beta1-$(shell git rev-parse --short=7 HEAD)
88
KATIB_REGISTRY := docker.io/kubeflowkatib
99
CPU_ARCH ?= amd64
10-
ENVTEST_K8S_VERSION ?= 1.28
10+
ENVTEST_K8S_VERSION ?= 1.29
1111
MOCKGEN_VERSION ?= $(shell grep 'github.com/golang/mock' go.mod | cut -d ' ' -f 2)
1212
GO_VERSION=$(shell grep '^go' go.mod | cut -d ' ' -f 2)
1313

@@ -23,7 +23,7 @@ test: envtest
2323

2424
envtest:
2525
ifndef HAS_SETUP_ENVTEST
26-
go install sigs.k8s.io/controller-runtime/tools/setup-envtest@8a64e5f3bd788d79be2396d21a29551fc49e46a8 #v0.16.5
26+
go install sigs.k8s.io/controller-runtime/tools/setup-envtest@bf15e44028f908c790721fc8fe67c7bf2d06a611 #v0.17.3
2727
$(info "setup-envtest has been installed")
2828
endif
2929
$(info "setup-envtest has already installed")

README.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -154,8 +154,8 @@ Follow the next steps to install Katib standalone.
154154

155155
This is the minimal requirements to install Katib:
156156

157-
- Kubernetes >= 1.26
158-
- `kubectl` >= 1.26
157+
- Kubernetes >= 1.27
158+
- `kubectl` >= 1.27
159159

160160
## Latest Version
161161

cmd/katib-controller/v1beta1/main.go

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,6 @@ import (
2626
"github.com/spf13/viper"
2727
"k8s.io/apimachinery/pkg/runtime"
2828
_ "k8s.io/client-go/plugin/pkg/client/auth/gcp"
29-
"sigs.k8s.io/controller-runtime/pkg/client/apiutil"
3029
"sigs.k8s.io/controller-runtime/pkg/client/config"
3130
"sigs.k8s.io/controller-runtime/pkg/healthz"
3231
logf "sigs.k8s.io/controller-runtime/pkg/log"
@@ -118,10 +117,6 @@ func main() {
118117
LeaderElection: initConfig.ControllerConfig.EnableLeaderElection,
119118
LeaderElectionID: initConfig.ControllerConfig.LeaderElectionID,
120119
Scheme: scheme,
121-
// TODO: Once the below issue is resolved, we need to switch discovery-client to the built-in one.
122-
// https://github.com/kubernetes-sigs/controller-runtime/issues/2354
123-
// https://github.com/kubernetes-sigs/controller-runtime/issues/2424
124-
MapperProvider: apiutil.NewDiscoveryRESTMapper,
125120
})
126121
if err != nil {
127122
log.Error(err, "Failed to create the manager")

0 commit comments

Comments
 (0)