Skip to content

Commit 327f763

Browse files
authored
[SDK] fix issue with serialization of LoraConfig (#2567)
Signed-off-by: Zackeus Bengtsson <[email protected]>
1 parent c9528e7 commit 327f763

File tree

1 file changed

+8
-3
lines changed
  • sdk/python/v1beta1/kubeflow/katib/utils

1 file changed

+8
-3
lines changed

sdk/python/v1beta1/kubeflow/katib/utils/utils.py

Lines changed: 8 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -188,8 +188,9 @@ def get_trial_substitutions_from_trainer(
188188
if isinstance(parameters, TrainingArguments):
189189
parameters_dict = parameters.to_dict()
190190
else:
191-
parameters_dict = parameters.__dict__
192-
191+
parameters_dict = (
192+
parameters.to_dict() if hasattr(parameters, "to_dict") else vars(parameters)
193+
)
193194
for p_name, p_value in parameters_dict.items():
194195
if not hasattr(parameters, p_name):
195196
logger.warning(f"Training parameter {p_name} is not supported.")
@@ -218,7 +219,11 @@ def get_trial_substitutions_from_trainer(
218219
if isinstance(parameters, TrainingArguments):
219220
parameters = json.dumps(parameters.to_dict())
220221
else:
221-
parameters = json.dumps(parameters.__dict__, cls=SetEncoder)
222+
parameters = (
223+
json.dumps(parameters.to_dict(), cls=SetEncoder)
224+
if hasattr(parameters, "to_dict")
225+
else json.dumps(vars(parameters), cls=SetEncoder)
226+
)
222227

223228
return parameters
224229

0 commit comments

Comments
 (0)